Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for downloading the wrong binary in the online compiler #10443

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
6 participants
@bridadan
Copy link
Contributor

commented Apr 18, 2019

Description

We've had this fix in the online compiler for quite some time, but bringing this mainline so we don't have to maintain it in our fork. This does not affect any compilations with Mbed CLI.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri (theotherjimmy is unavailable)

Release Notes

@ciarmcom ciarmcom requested review from SenRamakri and ARMmbed/mbed-os-maintainers Apr 18, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@bridadan, thank you for your changes.
@SenRamakri @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@SenRamakri any update on a review for this ?

@adbridge adbridge added needs: CI and removed needs: review labels Apr 26, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 360b7bb into ARMmbed:master Apr 30, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8129 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.