-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: Minor doc update for CellualrSocket object #10453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original comment tries to say that Socket ID must conform with modem's specification.
We probably want to refer only to 3GPP specs, and not to any specific modem (such as M26) at the generic AT implementation.
Socket ID is usually spitted out by the modem, however there are cases when the modem is actully taken in as an input argument, e.g., in the case of QUECTEL M26 modem. This minor knit clarifies that the CellularSocket::id can be an input argument.
e792c19
to
4eaffb4
Compare
@AriParkkila @mirelachirica The comment is rephrased. Please review again. |
@hasnainvirk, thank you for your changes. |
ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Socket ID is usually spitted out by the modem, however there are cases
when the modem is actully taken in as an input argument, e.g., in the
case of QUECTEL M26 modem. This minor knit clarifies that the
CellularSocket::id can be an input argument.
Pull request type
Reviewers
@blind-owl @AriParkkila @mirelachirica @AnttiKauppila
Release Notes