Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify PinName file to keep correspondence with spec #10578

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
4 participants
@ThunderSoft123
Copy link
Contributor

commented May 14, 2019

Description

PinNames update - using schematic to match the pin names - fixing naming

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170
Copy link
Member

left a comment

Can you describe changes in the Description? Why are these pins being changed? Why is this breaking change?

@0xc0170 0xc0170 added the needs: work label May 14, 2019

@ThunderSoft123

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@0xc0170 Sorry, I should select the Refactor. I modify the PIN to keep correspondence with Schematics.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 6a6dd02 into ARMmbed:master May 16, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8582 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.