Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify PinName file to keep correspondence with spec #10578

Merged
merged 1 commit into from
May 16, 2019
Merged

Modify PinName file to keep correspondence with spec #10578

merged 1 commit into from
May 16, 2019

Conversation

ThunderSoft123
Copy link
Contributor

@ThunderSoft123 ThunderSoft123 commented May 14, 2019 •
edited by 0xc0170
Loading

Description

PinNames update - using schematic to match the pin names - fixing naming

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

0xc0170
0xc0170 requested changes May 14, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe changes in the Description? Why are these pins being changed? Why is this breaking change?

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 Sorry, I should select the Refactor. I modify the PIN to keep correspondence with Schematics.

@0xc0170
Copy link
Contributor

0xc0170 commented May 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 6a6dd02 into ARMmbed:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ThunderSoft123 @0xc0170 @mbed-ci @adbridge