ARMC5: fix mbed_atomic_impl.h assembly #10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
May 20, 2019
|
CI started |
|
@SanaMasood - can you confirm that this fixes your build problems? (I reproduced and cleared them locally, but just to double-check as our CI systems are no longer testing ARMC5, which is how the error went unnoticed). |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Set as "needs: review" for the confirmation |
|
@0xc0170 yes it does, Please merge it to the main.. |
0xc0170
added
ready for merge
release-version: 5.13.0-rc1
and removed
needs: review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit #10147 didn't work for ARMC5 - patch the ARMC5 sections up.
Pull request type
Fix, but fixing something not in 5.12, so not for patch release.