Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMC5: fix mbed_atomic_impl.h assembly #10594

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
5 participants
@kjbracey-arm
Copy link
Contributor

commented May 16, 2019

Description

Commit #10147 didn't work for ARMC5 - patch the ARMC5 sections up.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Fix, but fixing something not in 5.12, so not for patch release.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 16, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

CI started

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

@SanaMasood - can you confirm that this fixes your build problems?

(I reproduced and cleared them locally, but just to double-check as our CI systems are no longer testing ARMC5, which is how the error went unnoticed).

@mbed-ci

This comment has been minimized.

Copy link

commented May 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels May 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@SanaMasood - can you confirm that this fixes your build problems?

Set as "needs: review" for the confirmation

@SanaMasood

This comment has been minimized.

Copy link

commented May 21, 2019

@0xc0170 yes it does, Please merge it to the main..

@0xc0170 0xc0170 merged commit e41d017 into ARMmbed:master May 21, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8614 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:atomic_armc5_fix branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.