-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C++14 sized delete operators #10707
Conversation
No test failures seen - it may be that the libraries were actually automatically redirecting from their sized version to our unsized. But suppresses a warning. |
@kjbracey-arm, thank you for your changes. |
Correct C++14 operation of the alloc wrappers requires us to define custom sized delete operators. Their presence won't cause any problem for people compiling as C++03 or C++11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kjbracey-arm for this addition. It is indeed mandatory to define these forms if we define the global version of the delete operator. One thing that can be improved: mark all delete
functions as noexcept
.
I've been assuming |
I don't think it will impact code generation however the default signatures are noexpect; my remark was just for consistency (see https://isocpp.org/files/papers/n3778.html). |
I guess I'm just being a bit coy at immediately flinging in non-C++03-compatible code without good reason. I believe the situation is that we're free to put non-C++03-compatible code in anything targetting 5.14, but this is targetted as a fix for 5.13, so we want it to remain C++03 compatible so people have the option to build as C++03 if they've got an application C++11 incompatibility, for the 5.13 release only. |
Any review from @ARMmbed/mbed-os-core ? |
CI started |
Test run: FAILEDSummary: 6 of 7 test jobs failed Failed test jobs:
|
Jenkins restarted, restarting the job now |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Correct C++14 operation of the alloc wrappers requires us to define
custom sized delete operators.
Their presence won't cause any problem for people compiling as C++03 or
C++11.
Pull request type