Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMC6: Suppress "register deprecated" warning #10740

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@kjbracey-arm
Copy link
Contributor

commented Jun 3, 2019

Description

Lots of target code, STM in particular, uses the register keyword, so
it'll take a little while to clean up. In the interim, some builds are
producing a lot of warnings. Suppress the warning for now, as register
remains legal C++14 and C11, despite C++14 deprecating it.

C++17 removes register, so code will need to be cleaned before any
further C++ version update.

Fixes #10717

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
ARMC6: Suppress "register deprecated" warning
Lots of target code, STM in particular, uses the `register` keyword, so
it'll take a little while to clean up. In the interim, some builds are
producing a lot of warnings. Suppress the warning for now, as `register`
remains legal C++14 and C11, despite C++14 deprecating it.

C++17 removes `register`, so code will need to be cleaned before any
further C++ version update.
@0xc0170

0xc0170 approved these changes Jun 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

It actually slows the compiler down a fair bit too as it has to print all the warnings, nearly 8000 of them on the F429!

This was copied from the issue reported, I believe this would be good to have in rc2

cc @adbridge

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Yes, should have mentioned that - that's the justification for it being a "fix".

(Plus some client test builds having warnings as errors?)

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-core Jun 3, 2019

@bulislaw
Copy link
Member

left a comment

Approved for RC2

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2019

@0xc0170 0xc0170 merged commit f174490 into ARMmbed:master Jun 4, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8659 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.