-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARMC6: Suppress "register deprecated" warning #10740
Conversation
Lots of target code, STM in particular, uses the `register` keyword, so it'll take a little while to clean up. In the interim, some builds are producing a lot of warnings. Suppress the warning for now, as `register` remains legal C++14 and C11, despite C++14 deprecating it. C++17 removes `register`, so code will need to be cleaned before any further C++ version update.
This was copied from the issue reported, I believe this would be good to have in rc2 cc @adbridge |
Yes, should have mentioned that - that's the justification for it being a "fix". (Plus some client test builds having warnings as errors?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for RC2
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Lots of target code, STM in particular, uses the
register
keyword, soit'll take a little while to clean up. In the interim, some builds are
producing a lot of warnings. Suppress the warning for now, as
register
remains legal C++14 and C11, despite C++14 deprecating it.
C++17 removes
register
, so code will need to be cleaned before anyfurther C++ version update.
Fixes #10717
Pull request type