Fixes in Sys Timer test #10744
Merged
Fixes in Sys Timer test #10744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not call sleep from the test thread, but let scheduler do it. And also include the deep sleep latency in the computation of the allowed delta for deep sleep test case.
mprse
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Approved.
Increasing of the delta value for the deep-sleep test case is consistent with the requirements:
Line 43 in f18e336
|
@LMESTM, thank you for your changes. |
0xc0170
approved these changes
Jun 3, 2019
|
@0xc0170 I think this PR has now been approved ? |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
|
restarting ci as this ran so long ago |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not call sleep from the test thread, but let scheduler do it.
And also include the deep sleep latency in the computation of the allowed
delta for deep sleep test case.
Issue was seen during testing #10701
@jeromecoutant @mprse
Pull request type
Reviewers
Release Notes