-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new features to Toshiba's TMPM3H6 #10874
Conversation
@ganesh-ramachandran, thank you for your changes. |
I'll review this one on Monday, sorry for the delay |
void rtc_free(void) | ||
{ | ||
if (flag) { // Check status of RTC peripheral driver is ENABLE or DISABLE | ||
flag = 0; // Set status of RTC peripheral driver is DISABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work? if target is reseted, won't RTC stay alive - means flag here would state it is not enabled by RTC is running? Shouldn't we rather check peripheral for status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170, RTC status register is not in Toshiba MCUs. However, verified with RTC initialized status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so no way to check RTC is already running - this is mainly after target resets itself , no need to reinit RTC (and loose time) ? or I've missed something
Looks fine just one RTC flag in question Sorry for the delay, was lost in notifications after vacation and release 😢 |
CI started meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
I'll mark this as ready for merge, just one last question (same as above): if target is reseted, is RTC reconfigured - do we loose the time stored? We had this problem previously in some targets (using variable initialized that is wiped everytime startup runs). |
@0xc0170, Yes, if target is reseted we will loose the time, since we do not have a RTC status register. Yes, we also checked few other targets which also uses variable. |
OK understood, the limitation of RTC. Still hard to believe there is no way for checking RTC has been initialized , good to go then |
Description
Add new features to Toshiba's TMPM3H6
Tested with all 3 toolchains and attached test logs:
M3H6_ARM_TestResults.txt
M3H6_GCC_ARM_TestResults.txt
M3H6_IAR_TestResults.txt
Pull request type
Reviewers
Release Notes