Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new features to Toshiba's TMPM3H6 #10874

Merged
merged 2 commits into from Jul 5, 2019
Merged

Add new features to Toshiba's TMPM3H6 #10874

merged 2 commits into from Jul 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2019

Description

Add new features to Toshiba's TMPM3H6

  • SPISlave
  • SPI_ASYNCH
  • SERIAL_FC
  • I2C_ASYNCH
  • RTC

Tested with all 3 toolchains and attached test logs:
M3H6_ARM_TestResults.txt
M3H6_GCC_ARM_TestResults.txt
M3H6_IAR_TestResults.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom
Copy link
Member

@ganesh-ramachandran, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team June 20, 2019 13:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2019

I'll review this one on Monday, sorry for the delay

void rtc_free(void)
{
if (flag) { // Check status of RTC peripheral driver is ENABLE or DISABLE
flag = 0; // Set status of RTC peripheral driver is DISABLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work? if target is reseted, won't RTC stay alive - means flag here would state it is not enabled by RTC is running? Shouldn't we rather check peripheral for status?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170, RTC status register is not in Toshiba MCUs. However, verified with RTC initialized status.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so no way to check RTC is already running - this is mainly after target resets itself , no need to reinit RTC (and loose time) ? or I've missed something

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2019

Looks fine just one RTC flag in question

Sorry for the delay, was lost in notifications after vacation and release 😢

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2019

CI started meanwhile

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

I'll mark this as ready for merge, just one last question (same as above): if target is reseted, is RTC reconfigured - do we loose the time stored? We had this problem previously in some targets (using variable initialized that is wiped everytime startup runs).

@ghost
Copy link
Author

ghost commented Jul 5, 2019

I'll mark this as ready for merge, just one last question (same as above): if target is reseted, is RTC reconfigured - do we loose the time stored? We had this problem previously in some targets (using variable initialized that is wiped everytime startup runs).

@0xc0170, Yes, if target is reseted we will loose the time, since we do not have a RTC status register. Yes, we also checked few other targets which also uses variable.

@ghost ghost mentioned this pull request Jul 5, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

OK understood, the limitation of RTC. Still hard to believe there is no way for checking RTC has been initialized ,

good to go then

@0xc0170 0xc0170 merged commit e08b713 into ARMmbed:master Jul 5, 2019
@ghost ghost deleted the m3h6_newfeatures branch July 29, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants