Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPGA I2C: correct init bloc number #11004

Merged
merged 1 commit into from
Jul 15, 2019
Merged

FPGA I2C: correct init bloc number #11004

merged 1 commit into from
Jul 15, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Nightly debug session

@c1728p9 @MarceloSalazar @LMESTM @mmahadevan108

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@c1728p9
Copy link
Contributor

c1728p9 commented Jul 9, 2019

CC: @mprse

@c1728p9
Copy link
Contributor

c1728p9 commented Jul 9, 2019

@mrcoulter45

@ciarmcom ciarmcom requested review from a team July 9, 2019 21:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 9, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

stevew817 added a commit to SiliconLabs/mbed-os that referenced this pull request Jul 9, 2019
@stevew817
Allow re-initializing an I2C peripheral
fb4d898 
Allows the FPGA based test to pass, but requires ARMmbed#11004 before it will
@stevew817 stevew817 mentioned this pull request Jul 9, 2019
Merged
@maciejbocianski
Copy link
Contributor

@jeromecoutant @c1728p9
How it was tested?
Looks like the STM's implementation of i2c_byte_read is broken - doesn't sends NACK when requested

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

CI started

c1728p9 pushed a commit to c1728p9/mbed-os that referenced this pull request Jul 10, 2019
@stevew817 @c1728p9
Allow re-initializing an I2C peripheral
0a73b1a 
Allows the FPGA based test to pass, but requires ARMmbed#11004 before it will
@c1728p9
Copy link
Contributor

c1728p9 commented Jul 10, 2019

@maciejbocianski, me and @jeromecoutant were testing with a NUCLEO_F429ZI. We used a logic analyzer to confirm that the F429 was sending correct I2C data.

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@jeromecoutant jeromecoutant changed the title FPFA I2C: correct init bloc number FPGA I2C: correct init bloc number Jul 10, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

CI internal issue, will restart once fixed

@mrcoulter45
Copy link
Contributor

@c1728p9 I remember you and I found a bug with Nucleo byte-read specifically where Mbed would send an extra ACK and an extra byte was incorrectly read whenever a NACK needed to be sent, which I believe caused num_reads to be off by 1. Just wanted to throw that out there to make sure it wasn't related to this issue, because I believe there actually is an issue with the Nucleo NACKing.

@maciejbocianski
Copy link
Contributor

@mrcoulter45 True, but not all STM targets fail with this error. F429ZI is free from this bug unlike to F070RB

@jeromecoutant
Copy link
Collaborator Author

@ARMmbed/team-st-mcd

@jeromecoutant
Copy link
Collaborator Author

but not all STM targets fail with this error. F429ZI is free from this bug unlike to F070RB

Didn't test F0 but agree to say it is OK with F4, not with L4...

@jeromecoutant
Copy link
Collaborator Author

me and @jeromecoutant were testing with a NUCLEO_F429ZI. We used a logic analyzer to confirm that the F429 was sending correct I2C data.

Yes, thank you Russ for the good job!
@AnotherButler sorry for this.. Happy birthday anyway :-)

@LMESTM

@LMESTM
Copy link
Contributor

LMESTM commented Jul 11, 2019

Yeah, big thanks to @c1728p9 and Happy birthday @AnotherButler ;-)

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 11, 2019

Tests restarted

evedon pushed a commit that referenced this pull request Jul 11, 2019
@stevew817
Allow re-initializing an I2C peripheral
918f70c 
Allows the FPGA based test to pass, but requires #11004 before it will
@mbed-ci
Copy link

mbed-ci commented Jul 12, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@evedon
Copy link
Contributor

evedon commented Jul 12, 2019

Greentea-test re-started

@artokin artokin merged commit 85a9022 into ARMmbed:master Jul 15, 2019
@jeromecoutant jeromecoutant deleted the PR_I2C branch July 16, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@maciejbocianski maciejbocianski maciejbocianski approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@jeromecoutant @c1728p9 @ciarmcom @maciejbocianski @0xc0170 @mbed-ci @mrcoulter45 @LMESTM @evedon @artokin