Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase ADC tolerance to 5% in FPGA-based tests #11014

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Increase ADC tolerance to 5% in FPGA-based tests #11014

merged 1 commit into from
Jul 17, 2019

Conversation

stevew817
Copy link
Contributor

Description

During the SiP workshop, we discovered that 3% is too narrow due to a combination of:

  • Voltage rail differences between target and FPGA
  • Extension of lesser-resolution ADC's to 16-bit results

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@c1728p9

Release Notes

@ciarmcom ciarmcom requested review from c1728p9 and a team July 10, 2019 11:00
@ciarmcom
Copy link
Member

@stevew817, thank you for your changes.
@c1728p9 @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the commit msg:

During the SiP workshop, we discovered that 3% is too narrow due to a combination of:
Voltage rail differences between target and FPGA
Extension of lesser-resolution ADC's to 16-bit results

@stevew817
Increase ADC test tolerance to 5%
f6a70b2 
During the SiP workshop, we discovered that 3% is too narrow due to a combination of:
Voltage rail differences between target and FPGA
Extension of lesser-resolution ADC's to 16-bit results
@stevew817 stevew817 force-pushed the fix/fpga_tests/adc_methodology branch from f1cdb98 to f6a70b2 Compare July 10, 2019 13:13
@stevew817
Copy link
Contributor Author

@0xc0170 Done.

@evedon
Copy link
Contributor

evedon commented Jul 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@artokin
Copy link
Contributor

artokin commented Jul 15, 2019

Looks like a CI problem, CI restarted.

@mbed-ci
Copy link

mbed-ci commented Jul 15, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 59b9f1d into ARMmbed:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@stevew817 @ciarmcom @evedon @mbed-ci @artokin @c1728p9 @0xc0170 @mprse @SeppoTakalo