Update MCUXpresso AnalogIn driver for LPC devices #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
1. Update the clock divider setting 2. ADC resolution is 12-bits, update the API return value to return 16-bit result 3. Update IOMUX setup Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
|
@mmahadevan108, thank you for your changes. |
bulislaw
approved these changes
Jul 16, 2019
| @@ -49,7 +49,7 @@ void analogin_init(analogin_t *obj, PinName pin) | |||
| ADC_ClockPower_Configuration(); | |||
|
|
|||
| /* Ensure the ADC clock derived from the system clock is less than 80MHz */ | |||
There was a problem hiding this comment.
The comments are not matching the code.
There was a problem hiding this comment.
The system clock is managed as BusClock by the internal clocking code structure :). Comment is correct but code needed to be changed.
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the MCUXpresso AnalogIn driver to pass the FPGA test shield tests. Below are updates
FPGA test result below:
mbedgt: test on hardware with target id: 105600001984a78e00000000000000000000000097969905
mbedgt: test suite 'mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin' ............................. OK in 15.02 sec
test case: 'AnalogIn - init test' ............................................................ OK in 0.40 sec
test case: 'AnalogIn - read test' ............................................................ OK in 0.40 sec
mbedgt: test case summary: 2 passes, 0 failures
Pull request type