Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mbed-os compile without DEVICE_SERIAL #11086

Merged

Conversation

@Tharazi97
Copy link
Contributor

commented Jul 22, 2019

Description

Added preprocessing #if statements so that Mbed-os can compile without DEVICE_SERIAL.
fixes #9850

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @maciejbocianski

@ciarmcom ciarmcom requested review from jamesbeyond, maciejbocianski and ARMmbed/mbed-os-maintainers Jul 22, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@Tharazi97, thank you for your changes.
@maciejbocianski @jamesbeyond @ARMmbed/mbed-os-maintainers please review.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo removed the needs: CI label Jul 23, 2019

@fkjagodzinski
Copy link
Member

left a comment

LGTM 👍

@fkjagodzinski

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Also, I can confirm this fixes build failures reported in #9850. Checked locally with SERIAL removed from targets.json and mbed compile -t GCC_ARM -m NUCLEO_L476RG command.

@SeppoTakalo SeppoTakalo merged commit 6ce2439 into ARMmbed:master Jul 25, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8633 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.