Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mbed-os compile without DEVICE_SERIAL #11086

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Mbed-os compile without DEVICE_SERIAL #11086

merged 1 commit into from
Jul 25, 2019

Conversation

Tharazi97
Copy link
Contributor

Description

Added preprocessing #if statements so that Mbed-os can compile without DEVICE_SERIAL.
fixes #9850

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @maciejbocianski

@ciarmcom ciarmcom requested review from jamesbeyond, maciejbocianski and a team July 22, 2019 15:00
@ciarmcom
Copy link
Member

@Tharazi97, thank you for your changes.
@maciejbocianski @jamesbeyond @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Jul 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

fkjagodzinski
fkjagodzinski approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fkjagodzinski
Copy link
Member

Also, I can confirm this fixes build failures reported in #9850. Checked locally with SERIAL removed from targets.json and mbed compile -t GCC_ARM -m NUCLEO_L476RG command.

@SeppoTakalo SeppoTakalo merged commit 6ce2439 into ARMmbed:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@jamesbeyond jamesbeyond Awaiting requested review from jamesbeyond

@maciejbocianski maciejbocianski Awaiting requested review from maciejbocianski

Assignees
No one assigned
Labels
release-version: 5.13.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GREENTEA can't compile is DEVICE_SERIAL is not enabled
6 participants
@Tharazi97 @ciarmcom @mbed-ci @fkjagodzinski @bulislaw @SeppoTakalo