Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force inline Timer::attach() to get rid of floating-point instructions #11236

Merged
merged 13 commits into from Aug 20, 2019
Merged

Force inline Timer::attach() to get rid of floating-point instructions #11236

merged 13 commits into from Aug 20, 2019

Commits on Aug 19, 2019

  1. Require integer to specify callback interval with Ticker API 

    * Create new `s_timestamp_t` type to specify timestamp is seconds
* Alter `attach()` API to expect `s_timestamp_t` for interval value
* Create helper macro to convert seconds to milliseconds and help code
  readability
* Modify Greentea tests accordingly
    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    e1714ec View commit details
    Browse the repository at this point in the history

  2. Deprecate previous Ticker::attach() API 

    * Restore previous implementation as deprecated
* Ensure method call is unambiguous
    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    4b1cee3 View commit details
    Browse the repository at this point in the history

  3. Move time macro conversions to Ticker.h

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    ce5dbda View commit details
    Browse the repository at this point in the history

  4. Add new API method attach_s instead of overloading the deprecated `… 

    …attach`
    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    61b1482 View commit details
    Browse the repository at this point in the history

  5. Ensure tests use the new method.

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    80cdc3e View commit details
    Browse the repository at this point in the history

  6. Fix lp_ticker and ticker unit test case wait times

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    d6429ef View commit details
    Browse the repository at this point in the history

  7. Fix code indentation to satisfy code style checker

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    59a6b55 View commit details
    Browse the repository at this point in the history

  8. Ensure the new method is called by the deprecated one

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    b0d4b69 View commit details
    Browse the repository at this point in the history

  9. Force inline Timer::attach() to get rid of floating-point instruction 

    Calls to Timer::attach() are inlined in order not to use floating-point
library functions calls given Timer::attach_us() expects an integer
for the callback interval.
    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    5635e94 View commit details
    Browse the repository at this point in the history

  10. Use Perfect forwading to pass arguments from attach() to attach_us() 

    This prevents a possible heavy callback copy.
    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    e06c91c View commit details
    Browse the repository at this point in the history

  11. Un-templatise interval and forward the reference 

    Also fix code style to please style checker
    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    9cc816d View commit details
    Browse the repository at this point in the history

  12. Include mstd_utility to get in front of the ARMC5's built-in utility

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    7ec84a8 View commit details
    Browse the repository at this point in the history

  13. Rename hal/rtc test callback to avoid overloading

    @hugueskamba
    hugueskamba committed Aug 19, 2019
    Copy the full SHA
    3373d78 View commit details
    Browse the repository at this point in the history