Netsocket: Change DNS retry and total attempt counts #11244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AriParkkila, thank you for your changes. |
kivaisan
approved these changes
Aug 19, 2019
AnttiKauppila
approved these changes
Aug 19, 2019
It should contain release notes addition above. please add it |
0xc0170
requested changes
Aug 19, 2019
|
Started CI meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@0xc0170 Updated Release Notes. |
0xc0170
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current DNS defaults, DNS query is sent
dns-retries+1times to the first server if no response is received. DNS should continue sending queries to another DNS server, but becausedns-total-attemptslimits query count to 3, DNS stops and returns failure.This change updates DNS counters so that each of five predefined servers are tried twice.
Pull request type
Reviewers
@kivaisan
Release Notes
DNS lookup is done for each of five predefined servers twice. This change affects the previous DNS lookup functionality only when it's expected that DNS is made three times on the very first DNS server.
Although that's unlikely needed, the previous functionality can be restored reverting the changes to DNS configuration.