Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netsocket: Change DNS retry and total attempt counts #11244

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@AriParkkila
Copy link
Contributor

commented Aug 16, 2019

Description

With the current DNS defaults, DNS query is sent dns-retries+1 times to the first server if no response is received. DNS should continue sending queries to another DNS server, but because dns-total-attempts limits query count to 3, DNS stops and returns failure.

This change updates DNS counters so that each of five predefined servers are tried twice.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kivaisan

Release Notes

DNS lookup is done for each of five predefined servers twice. This change affects the previous DNS lookup functionality only when it's expected that DNS is made three times on the very first DNS server.
Although that's unlikely needed, the previous functionality can be restored reverting the changes to DNS configuration.

@ciarmcom ciarmcom requested review from kivaisan and ARMmbed/mbed-os-maintainers Aug 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@AriParkkila, thank you for your changes.
@kivaisan @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-ipcore Aug 16, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

[x] Functionality change

It should contain release notes addition above. please add it

Copy link
Member

left a comment

Waiting for detailed release notes section

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Started CI meanwhile

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@0xc0170 Updated Release Notes.

@0xc0170 0xc0170 merged commit ff4dac9 into ARMmbed:master Aug 21, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8648 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.