Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal fhss timer: removed unnecessary and potentially unsafe memset #11250

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@JarkkoPaso
Copy link
Contributor

commented Aug 16, 2019

Description

hal fhss timer: removed unnecessary and potentially unsafe memset

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 16, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@JarkkoPaso, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

While you're here, could you make the structure type and array not global?

Stick namespace { } around both the type and array to put them in an anonymous namespace. You could actually do that for all your other objects above, instead of the statics.

See bit about anonymous namespaces in the Organization section of https://os.mbed.com/docs/mbed-os/v5.13/contributing/software-design.html

static is fine for objects, but doesn't work for the types - namespace { } handles both.

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Actually, all your currently-static functions and the using declarations could be in the anonymous namespace rather than static. Would keep the style consistent within the file. Only the fhss_functions needs to be global.

Technically fhss_functions should be declared extern "C", if you're accessing it from C code, but I don't think any of our toolchains care.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Aug 19, 2019

@0xc0170
Copy link
Member

left a comment

Above ^^

@JarkkoPaso

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@kjbracey-arm please review again

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit cf6fbda into ARMmbed:master Aug 23, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+48 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8858 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@JarkkoPaso always provide description please. It is required. I fixed it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.