Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266Interface buffer null-terminated and parameters of scan function in correct order #11427

Merged
merged 1 commit into from
Sep 6, 2019
Merged

ESP8266Interface buffer null-terminated and parameters of scan function in correct order #11427

merged 1 commit into from
Sep 6, 2019

Conversation

dmaziec
Copy link
Contributor

@dmaziec dmaziec commented Sep 5, 2019 •
edited
Loading

Description

According to Coverity warnings:
In ESP8266Interface::set_credentials(...) buffer ap_ssid is null-terminated.
Scan function parameters are passed in correct order.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@michalpasztamobica
@kjbracey-arm

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Sep 5, 2019

@dmaziec1, thank you for your changes.
@SeppoTakalo @kjbracey-arm @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

VeijoPesonen
VeijoPesonen approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine this time but logically these two fixes should be separated on two different commits as those are unrelated.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 9da5c22 into ARMmbed:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

Assignees
No one assigned
Labels
release-version: 5.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dmaziec @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @VeijoPesonen @michalpasztamobica