ESP8266 Unified Mbed trace prints. #11460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,7 @@ ESP8266Interface::ESP8266Interface() | |||
| _oob_event_id(0), | |||
| _connect_event_id(0) | |||
| { | |||
| mbed_trace_init(); | |||
There was a problem hiding this comment.
I assume this should have been removed.
dmaziec
force-pushed
the
esp8266_new_trace_debug_logs
branch
from
6071293
to
2a340da
Compare
ciarmcom
requested review from
AnttiKauppila,
michalpasztamobica,
SeppoTakalo,
VeijoPesonen and
a team
|
@dmaziec1, thank you for your changes. |
0xc0170
approved these changes
Sep 12, 2019
Isn't this a fix rather? unifying debug messages. |
VeijoPesonen
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Please update the PR's description based on @0xc0170´s comment. Otherwise this is ready to go in from my point of view.
All logs now: - start with a function name (it is not automatically logged by the logger) - do not contain class name (this can be inferred from log preamble) - message starts with a capital letter and ends with a full-stop
dmaziec
force-pushed
the
esp8266_new_trace_debug_logs
branch
from
2a340da
to
66bf8bc
Compare
michalpasztamobica
approved these changes
Sep 16, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This is sitting on top of changes for 6.0 thus bumping |
adbridge
added
release-version: 6.0.0-alpha-1
0xc0170
added
release-version: 5.15.0-rc1
and removed
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All logs now:
Pull request type
Reviewers
@VeijoPesonen
@SeppoTakalo
@AnttiKauppila
@michalpasztamobica
Release Notes