Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix added to unlock AT handler mutex #11526

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@fahim-ublox
Copy link
Contributor

commented Sep 19, 2019

Description

Fix added to unlock AT handler mutex introduced in mbed-os 5.14 release candidates

Targets verified with this fix : UBLOX_C030_U201 & UBLOX_C030_R412M

Pull request type

[X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@RobMeades @MarceloSalazar @AriParkkila

Release Notes

In mbed-os 5.14 release candidate1 and 2, none of u-blox modem is working due to this problem

@fahim-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

@MarceloSalazar Will this fix be part of mbed-os release 5.14 ? Thanks

@@ -116,6 +116,7 @@ nsapi_error_t UBLOX_AT::init()
err = _at->at_cmd_discard("+CFUN", "=1"); // set full functionality
}
#endif
_at->unlock();

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Sep 19, 2019

Contributor

Could be return _at.unlock_return_error(); ?

This comment has been minimized.

Copy link
@fahim-ublox

fahim-ublox Sep 19, 2019

Author Contributor

updated, thanks

@adbridge adbridge added the needs: CI label Sep 19, 2019
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Sep 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 19, 2019
@0xc0170 0xc0170 merged commit 4c9282f into ARMmbed:master Sep 19, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9776 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.