Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up unit test build with parallel jobs #11568

Merged
merged 1 commit into from Sep 27, 2019
Merged

Speed up unit test build with parallel jobs #11568

merged 1 commit into from Sep 27, 2019

Conversation

JuhPuur
Copy link
Contributor

@JuhPuur JuhPuur commented Sep 26, 2019

Description

Currently unit test build uses only one core. Allowing the use of all accessable cores cut build time by about 65% in testing with 8 cores.
No new dependencies, psutil is already in requirements.txt

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170 0xc0170 requested a review from a team September 26, 2019 13:13
OPpuolitaival
OPpuolitaival approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2019

Ci started

@adbridge adbridge merged commit 60a8a9d into ARMmbed:master Sep 27, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

How was this coordinated if now unittests are failing (needs CI update) ?

@SeppoTakalo
Copy link
Contributor

@OPpuolitaival @JuhPuur

Quite interesting.. why did this not run the unittest?
That CI image seems missing psutils, so you need to update the image or revert this temporary.

@JuhPuur
Copy link
Contributor Author

JuhPuur commented Sep 30, 2019

@SeppoTakalo investigating that. Did a quick fix in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JuhPuur @0xc0170 @SeppoTakalo @OPpuolitaival @adbridge