-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qspi frequency test fix #11631
Qspi frequency test fix #11631
Conversation
Prevent setting frequency below QSPI_MIN_FREQUENCY
according to the driver limitations
@maciejbocianski, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this min is set to the value 2000000?
Reviewers please look at this PR |
I scheduled CI to get early test results |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
Tests completed.
@maciejbocianski Can you answer? Also reviewers review, lets take this in soon. |
Setting frequency below 2MHz cause that basediv gets value larger then allowed max causing undefined behavior and errors in following testcases. mbed-os/targets/TARGET_Silicon_Labs/TARGET_EFM32/emlib/inc/em_qspi.h Lines 188 to 197 in 9534327
|
Restarted CI We shall progress with this fix today. |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
Description
qspi_frequency_test
: prevent setting frequency below QSPI_MIN_FREQUENCYPull request type
Reviewers
@jamesbeyond
Release Notes