Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qspi frequency test fix #11631

Merged
merged 2 commits into from Oct 28, 2019

Conversation

@maciejbocianski
Copy link
Member

maciejbocianski commented Oct 4, 2019

Description

  • fix qspi_frequency_test: prevent setting frequency below QSPI_MIN_FREQUENCY
  • adjust min frequency for EFM32GG11 target for hal qspi test

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

Release Notes

Prevent setting frequency below QSPI_MIN_FREQUENCY
according to the driver limitations
@ciarmcom ciarmcom requested review from jamesbeyond and ARMmbed/mbed-os-maintainers Oct 4, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 4, 2019

Copy link
Member

0xc0170 left a comment

Why this min is set to the value 2000000?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 17, 2019

Reviewers please look at this PR

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

I scheduled CI to get early test results

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

Tests completed.

Why this min is set to the value 2000000?

@maciejbocianski Can you answer?

Also reviewers review, lets take this in soon.

@maciejbocianski

This comment has been minimized.

Copy link
Member Author

maciejbocianski commented Oct 21, 2019

Setting frequency below 2MHz cause that basediv gets value larger then allowed max causing undefined behavior and errors in following testcases.

/** QSPI initialization structure. */
typedef struct {
/** Enable/disable Quad SPI when initialization is completed. */
bool enable;
/**
* Master mode baude rate divisor. Values can be even numbers in the range
* [2-32] inclusive. */
uint8_t divisor;
} QSPI_Init_TypeDef;

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

Restarted CI

We shall progress with this fix today.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 28, 2019
@0xc0170 0xc0170 merged commit 87a5e47 into ARMmbed:master Oct 28, 2019
19 checks passed
19 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8716 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.