Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change imgtool lib import to relative import #11638

Merged
merged 1 commit into from Oct 8, 2019
Merged

Change imgtool lib import to relative import #11638

merged 1 commit into from Oct 8, 2019

Conversation

JuhPuur
Copy link
Contributor

@JuhPuur JuhPuur commented Oct 7, 2019

Description

Building for ARM_MUSCA_A1_NS with python 3

python tools/psa/release.py -m ARM_MUSCA_A1_S
python -m mbed test --compile -j 8 -m ARM_MUSCA_A1_NS -t ARM --build-data BUILD/tests/build_data.json -DMBED_HEAP_STATS_ENABLED=1 -DMBED_STACK_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 -DMBED_ALL_STATS_ENABLED -DSKIP_TIME_DRIFT_TESTS=1

shows that imgtool has an import problem.

  File "/home/juhpuu01/build_test/mbed-os/tools/psa/tfm/bin_utils/imgtool.py", line 22, in <module>
    from imgtool_lib import keys
ModuleNotFoundError: No module named 'imgtool_lib'

This is easily fixed by changing to a relative import.
Tested to be compatible for python 2.7.15 and 3.6.8

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Oct 7, 2019

@JuhPuur, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team October 7, 2019 09:00
@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@OPpuolitaival
Copy link
Contributor

Looks good

@OPpuolitaival
Copy link
Contributor

@adbridge could we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants