Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed mbed gpio-port api to match gpio api #11690

Merged

Conversation

@shuopeng-deng
Copy link

shuopeng-deng commented Oct 15, 2019

Description

The port configuration api was not correctly setting the port-pins'
direction. Changed the port driver to call the gpio driver for
configuration (read and write still are optimized for port-level
operations) so that the behavior is consistent.

GT-CY8CPROTO_062_4343W-GCC_ARM.txt
GT-CY8CKIT_062_WIFI_BT-GCC_ARM.txt

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

The port configuration api was not correctly setting the port-pins'
direction. Changed the port driver to call the gpio driver for
configuration (read and write still are optimized for port-level
operations) so that the behavior is consistent.
@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Oct 15, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 15, 2019

@shuopeng-deng, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

obj->port->OUT_CLR = (~value) & obj->mask;
GPIO_PRT_Type *port_type = Cy_GPIO_PortToAddr(obj->port);
if (obj->mask == 0xff)
{

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Oct 21, 2019

Member

can you fix the style, { should be attached in this function as the rest of the file has it

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

Just one styling issue, otherwise looks fine to me

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

I was able to fix the styling, starting CI now

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 21, 2019
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 22, 2019
@0xc0170 0xc0170 merged commit 83207ae into ARMmbed:master Oct 22, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8759 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.