-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed mbed gpio-port api to match gpio api #11690
Changed mbed gpio-port api to match gpio api #11690
Conversation
The port configuration api was not correctly setting the port-pins' direction. Changed the port driver to call the gpio driver for configuration (read and write still are optimized for port-level operations) so that the behavior is consistent.
@shuopeng-deng, thank you for your changes. |
obj->port->OUT_CLR = (~value) & obj->mask; | ||
GPIO_PRT_Type *port_type = Cy_GPIO_PortToAddr(obj->port); | ||
if (obj->mask == 0xff) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the style, {
should be attached in this function as the rest of the file has it
Just one styling issue, otherwise looks fine to me |
I was able to fix the styling, starting CI now |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
The port configuration api was not correctly setting the port-pins'
direction. Changed the port driver to call the gpio driver for
configuration (read and write still are optimized for port-level
operations) so that the behavior is consistent.
GT-CY8CPROTO_062_4343W-GCC_ARM.txt
GT-CY8CKIT_062_WIFI_BT-GCC_ARM.txt
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes