-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ethernet memory handling issues on CM3DS #11843
Conversation
Signed-off-by: Bence Kaposzta <bence.kaposzta@arm.com>
features/netsocket/emac-drivers/TARGET_ARM_SSG/COMPONENT_SMSC9220/smsc9220_emac.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't actually see a leak being fixed here. The length is now being set correctly on received packets, rather than just indicating "full size", but doesn't seem like that would have caused a leak. Can you clarify?
features/netsocket/emac-drivers/TARGET_ARM_SSG/COMPONENT_SMSC9220/smsc9220_emac.cpp
Outdated
Show resolved
Hide resolved
@kapi90, thank you for your changes. |
Signed-off-by: Bence Kaposzta <bence.kaposzta@arm.com>
This is an older patch that has been pushed back due to priority changes since March, it seems that most of the memory leak related changes has been applied previously (our local repo must have got out of sync somewhere). Therefore, please consider this as a minor follow up. |
Started first CI |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
features/netsocket/emac-drivers/TARGET_ARM_SSG/COMPONENT_SMSC9220/smsc9220_emac.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bence Kaposzta <bence.kaposzta@arm.com>
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Signed-off-by: Bence Kaposzta bence.kaposzta@arm.com
Description (required)
There had been a memory leak in the SMSC9220's EMAC driver that is fixed in this patch.
Summary of change (What the change is for and why)
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required