Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ethernet memory handling issues on CM3DS #11843

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Conversation

kapi90
Copy link
Contributor

@kapi90 kapi90 commented Nov 11, 2019

Signed-off-by: Bence Kaposzta bence.kaposzta@arm.com

Description (required)

There had been a memory leak in the SMSC9220's EMAC driver that is fixed in this patch.

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

Signed-off-by: Bence Kaposzta <bence.kaposzta@arm.com>
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't actually see a leak being fixed here. The length is now being set correctly on received packets, rather than just indicating "full size", but doesn't seem like that would have caused a leak. Can you clarify?

@ciarmcom ciarmcom requested review from ashok-rao and a team November 11, 2019 14:00
@ciarmcom
Copy link
Member

@kapi90, thank you for your changes.
@ashok-rao @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

Signed-off-by: Bence Kaposzta <bence.kaposzta@arm.com>
@kapi90
Copy link
Contributor Author

kapi90 commented Nov 11, 2019

I can't actually see a leak being fixed here. The length is now being set correctly on received packets, rather than just indicating "full size", but doesn't seem like that would have caused a leak. Can you clarify?

This is an older patch that has been pushed back due to priority changes since March, it seems that most of the memory leak related changes has been applied previously (our local repo must have got out of sync somewhere). Therefore, please consider this as a minor follow up.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2019

Started first CI

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

Signed-off-by: Bence Kaposzta <bence.kaposzta@arm.com>
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants