Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed greentea minimal-printf test for microlib #11925

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Fixed greentea minimal-printf test for microlib #11925

merged 2 commits into from
Nov 22, 2019

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Nov 22, 2019 •
edited
Loading

Description

Added the !defined(__MICROLIB) guard in minimal-printf test case where snprintf() function called with zero size to skip due to the microlib snprintf() bug [https://jira.arm.com/browse/SDCOMP-54710].

Summary of change

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @hugueskamba

Release Notes

Summary of changes

Impact of changes

Migration actions required

@rajkan01 rajkan01 changed the title Baremetal: Fix ARM-microlib Greentea test compilation minimal-printf … Fixed greentea minimal-printf test for microlib Nov 22, 2019
0xc0170
0xc0170 requested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see as well some spaces (see travis astyle failures).

TESTS/mbed_platform/minimal-printf/compliance/main.cpp Outdated Show resolved Hide resolved
@rajkan01 rajkan01 force-pushed the feature-gt-bare-metal-minimal-printf branch from 7f97cb9 to 2fa57d6 Compare November 22, 2019 11:42
@0xc0170 0xc0170 requested a review from a team November 22, 2019 14:30
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2019

I'll start CI

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 9ca69cf into ARMmbed:master Nov 22, 2019
@0xc0170 0xc0170 removed the needs: CI label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rajkan01 @0xc0170 @mbed-ci @evedon