DNS tests: Cancel asynchronous dns query if it times out #11936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this test case if asynchronous DNS request results does not happen in requested time, the request must be cancelled to ensure it does not happen later on when test has exited already. We've seen couple of crashes in CI tests which indicate this kind of behaviour but this is very difficult to reproduce.
AriParkkila
approved these changes
Nov 25, 2019
|
@kivaisan, thank you for your changes. |
AriParkkila
approved these changes
Nov 25, 2019
0xc0170
approved these changes
Nov 25, 2019
kjbracey
approved these changes
Nov 25, 2019
|
What's the fix version for this PR? |
michalpasztamobica
approved these changes
Nov 25, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
CI restarted |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of change
In this test case if asynchronous DNS request results does not happen
in requested time, the request must be cancelled to ensure it does not
happen later on when test has exited already.
We've seen couple of crashes in CI tests which indicate this kind of behaviour
but this is very difficult to reproduce.
Documentation
Pull request type
Test results
Reviewers
@AriParkkila @tymoteuszblochmobica
Release Notes
Summary of changes
Impact of changes
Migration actions required