NUC472/M487: Limit EMAC receive frame length as 1518 #12057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
reviewed
Dec 9, 2019
| @@ -262,6 +262,8 @@ void numaker_eth_init(uint8_t *mac_addr) | |||
| EMAC_CAMCTL_ABP_Msk; | |||
| EMAC->CAMEN = 1; // Enable CAM entry 0 | |||
|
|
|||
| /* Limit the max receive frame length to 1514 + 4 */ | |||
| EMAC->MRFL = 1518; | |||
There was a problem hiding this comment.
Should this not be expressed based on NU_ETH_MAX_FLEN or PACKET_BUFFER_SIZE?
It might be that those are not quite defined right - I would expect the NU_ETH_MAX_FLEN to be 1518, not 1520, and then maybe PACKET_BUFFER_SIZE should be that rounded up to 1520 (multiple of 4).
There was a problem hiding this comment.
@kjbracey-arm, thanks of your advisement, I correct the definition & relative code in this commit 42103f0.
|
@cyliangtw, thank you for your changes. |
kjbracey
approved these changes
Dec 10, 2019
0xc0170
approved these changes
Dec 10, 2019
0xc0170
added
needs: CI
release-version: 6.0.0-alpha-1
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Limit the max receive frame length of EMAC to (1514 + 4) bytes.
According to the EMAC H/W design, this setting could avoid the risk of SRAM overwrite as while come-in some long packet over 1518 bytes.
Documentation
None
Pull request type
Test results
Reviewers