Microlib: Disable feof function usage in general filesystem test #12111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
reviewed
Dec 16, 2019
| @@ -105,7 +105,12 @@ int lfs_emubd_read(const struct lfs_config *cfg, lfs_block_t block, | |||
| } | |||
|
|
|||
| size_t res = fread(data, 1, size, f); | |||
| if (res < size && !feof(f)) { | |||
| if (res < size | |||
| #if !defined(__MICROLIB) | |||
There was a problem hiding this comment.
I wonder if this && !feof(f) test should ever be there.
Why would it be valid to attempt to read off the end of the file?
There was a problem hiding this comment.
As discussed with Kevin this feof check seems to be wrong but I will revert this changes as build system ignores this emubd due to .mbedignore.
|
@rajkan01, thank you for your changes. |
rajkan01
force-pushed
the
feature_feof_disable
branch
from
a3c0670
to
9c513bc
Compare
rajkan01
changed the title
rajkan01
changed the title
kjbracey
approved these changes
Dec 16, 2019
rajkan01
changed the title
rajkan01
force-pushed
the
feature_feof_disable
branch
from
9c513bc
to
890c692
Compare
feof function is not supported in Microlib library. so disabling all the feof function usage in the green tea test.
rajkan01
force-pushed
the
feature_feof_disable
branch
from
890c692
to
95f56ba
Compare
evedon
approved these changes
Dec 16, 2019
0xc0170
approved these changes
Dec 17, 2019
hugueskamba
approved these changes
Dec 17, 2019
|
CI started |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
adbridge
added
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
feof function is not supported in Microlib library refer "http://arminfo.emea.arm.com/help/index.jsp?topic=/com.arm.doc.100073_0612_00_en/chr1358938938431.html" for more info. so disabling all the feof function usage in the green tea test.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@evedon @hugueskamba