-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update watchdog tests to run with bare metal profile #12182
Update watchdog tests to run with bare metal profile #12182
Conversation
Replace the thread used in the test case teardown with a Ticker to allow testing with the bare metal profile. This Ticker is used to prevent the watchdog from resetting the device during the final greentea communication.
@rajkan01 could you verify these changes actually work with the bare-metal profile, please? |
I have tested the changes on this DISCO_L475VG_IOT01A target and it works. |
@fkjagodzinski, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
CI started |
CI aborted, update incoming |
Test run: FAILEDSummary: 4 of 4 test jobs failed Failed test jobs:
|
CI restarted |
Test run: FAILEDSummary: 1 of 5 test jobs failed Failed test jobs:
|
Looks like the very first test case failed with a serial error before the test had even started. All 3 of 3 tries failed.
The next test case failed with the serial error once (1/3) but then run OK. Can we simply rerun the tests, or does this require further investigation? |
tests restarted |
Summary of changes
Replace the
Thread
used in the test case teardown with aTicker
to allow testing with the bare metal profile. This Ticker is used to prevent the watchdog from resetting the device during the final greentea communication.Remove the
[NOT_SUPPORTED]
error for non-ROTS builds.Impact of changes
With this patch all the HAL & driver Watchdog tests may run with the bare-metal profile.
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@jamesbeyond, @rajkan01