Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watchdog tests to run with bare metal profile #12182

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Jan 2, 2020

Summary of changes

Replace the Thread used in the test case teardown with a Ticker to allow testing with the bare metal profile. This Ticker is used to prevent the watchdog from resetting the device during the final greentea communication.

Remove the [NOT_SUPPORTED] error for non-ROTS builds.

Impact of changes

With this patch all the HAL & driver Watchdog tests may run with the bare-metal profile.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond, @rajkan01


Replace the thread used in the test case teardown with a Ticker to allow
testing with the bare metal profile. This Ticker is used to prevent the
watchdog from resetting the device during the final greentea
communication.
@fkjagodzinski
Copy link
Member Author

@rajkan01 could you verify these changes actually work with the bare-metal profile, please?

@rajkan01
Copy link
Contributor

rajkan01 commented Jan 2, 2020

@rajkan01 could you verify these changes actually work with the bare-metal profile, please?

I have tested the changes on this DISCO_L475VG_IOT01A target and it works.

@ciarmcom ciarmcom requested review from jamesbeyond, rajkan01 and a team January 2, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 2, 2020

@fkjagodzinski, thank you for your changes.
@jamesbeyond @rajkan01 @ARMmbed/mbed-os-core @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Jan 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

CI aborted, update incoming

@fkjagodzinski
Copy link
Member Author

Added 9523307 (cherry-picked from #12183).

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2020

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2020

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@fkjagodzinski
Copy link
Member Author

Looks like the very first test case failed with a serial error before the test had even started. All 3 of 3 tries failed.

[1578049664.19][HTST][ERR] remote write error: Write response(request_id: 347985d0-2e19-11ea-a497-0242ac110007) timeout!
(...)
[1578049664.19][HTST][INF] {{result;ioerr_serial}}
(...)
mbedgt: test suite 'tests-mbed_hal-watchdog' ......................................................... IOERR_SERIAL in 41.53 sec
	test case: 'tests-mbed_hal-watchdog' ......................................................... ERROR in 41.53 sec

The next test case failed with the serial error once (1/3) but then run OK. Can we simply rerun the tests, or does this require further investigation?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

tests restarted

@0xc0170 0xc0170 removed the needs: CI label Jan 3, 2020
@0xc0170 0xc0170 merged commit 7090448 into ARMmbed:master Jan 3, 2020
@fkjagodzinski fkjagodzinski deleted the test_update-watchdog_teardown branch January 3, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants