-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unittest: fix coverage filtering #12263
unittest: fix coverage filtering #12263
Conversation
change coverage filter pattern from ^pattern* to *pattern*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
CI started |
@AnttiKauppila , FYI: now we can get |
Test run: SUCCESSSummary: 1 of 1 test jobs passed |
@maciejbocianski, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@AnttiKauppila @michalpasztamobica @jamesbeyond |
@maciejbocianski , that explains why Seppo called his tests |
Summary of changes
Changes coverage filter pattern from
^pattern*
to*pattern*
to better match source filesBelow coverage reports generated by command
mbed test --unittest -r Socket --coverage html
unittests matched with
-r Socket
:without fix
with fix
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@jamesbeyond
@michalpasztamobica
@lorjala