BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81 #12270

VeijoPesonen · 2020-01-16T15:24:38Z

Summary of changes

Fixes #11722. Value of the SFDP Sector Map Table Parameter ID LSB is 0x81, not 81 in decimal.

Starts also the work where SFDP specific functionality is split from the SPIF and QSPIF Blockdevices to a separate file. At the moment it means retrieval and parsing of the SFDP- and SFDP Parameter-headers.

Impact of changes

Migration actions required

Documentation

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

SPIF compilation

mbed test --compile -t ARM -m NRF52840_DK -n features-storage-filesystem-littlefs-* --app-config tools/test_configs/SPIFBlockDeviceAndHeapBlockDevice.json

QSPIF compilation

mbed test --compile -t GCC_ARM -m NRF52840_DK -n features-storage-filesystem-littlefs-* --app-config tools/test_configs/QSPIFBlockDeviceAndHeapBlockDevice.json


| target              | platform_name | test suite                                                                           | result | elapsed_time (sec) | copy_method |
|---------------------|---------------|--------------------------------------------------------------------------------------|--------|--------------------|-------------|
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-dirs                           | OK     | 156.3              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-files                          | OK     | 69.58              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-interspersed                   | OK     | 22.98              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-seek                           | OK     | 132.63             | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_integration-format             | OK     | 36.4               | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_recovery-resilience            | OK     | 46.25              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_recovery-resilience_functional | OK     | 72.35              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_recovery-wear_leveling         | OK     | 91.87              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-dirs                  | OK     | 151.3              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-files                 | OK     | 57.79              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-interspersed          | OK     | 22.54              | default     |
| NRF52840_DK-ARMC6   | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-seek                  | OK     | 119.92             | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-dirs                           | OK     | 56.22              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-files                          | OK     | 36.87              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-interspersed                   | OK     | 23.01              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem-seek                           | OK     | 64.11              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_integration-format             | OK     | 24.94              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_recovery-resilience            | OK     | 48.27              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_recovery-resilience_functional | OK     | 72.97              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_recovery-wear_leveling         | OK     | 92.72              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-dirs                  | OK     | 65.92              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-files                 | OK     | 32.92              | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-interspersed          | OK     | 22.8               | default     |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | features-storage-filesystem-littlefs-tests-filesystem_retarget-seek                  | OK     | 79.63              | default     |
mbedgt: test suite results: 24 OK

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@SeppoTakalo

The Sector Map Function Specific Table is assigned the ID LSB of 81 in hexadecimal, not in decimal[1]. [1] JESD216.01 p. 53

ciarmcom · 2020-01-16T16:00:42Z

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @ARMmbed/mbed-os-core @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2020-01-17T10:05:02Z

@VeijoPesonen Please review Travis failures

SFDP logic is the same between SPIF and QSIP.

VeijoPesonen · 2020-01-17T13:43:17Z

@0xc0170 , @SeppoTakalo astyle and doxygen issues has been fixed now.

Separates SFDP header retrieval and moves it as a part of the earlier introduced SFDP file. Purpose is to abstract away differences between SPIF and QSPIF devices when it comes to fetching the SFDP headers from a device.

adbridge · 2020-01-20T15:36:17Z

@0xc0170 @SeppoTakalo could you please confirm you are happy with the latest changes ?

adbridge · 2020-01-21T16:43:17Z

CI started

mbed-ci · 2020-01-21T17:32:58Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

VeijoPesonen · 2020-01-22T08:01:38Z

~~@adbridge I need some help here because I'm unable to decipher from the logs what is going wrong in this case.~~ Scratch that, I should have checked from the most obvious place first...

One of the issues

The issues don't seem to be caused by the changes I made.


[DEBUG] Return: 1
[DEBUG] Output: In file included from ./source/borderrouter_tasklet.c:32:
[DEBUG] Output: ./source/static_6lowpan_config.h:11:33: error: use of undeclared identifier 'MBED_CONF_APP_PSK_KEY'
[DEBUG] Output: static const char psk_key[16] = MBED_CONF_APP_PSK_KEY;
[DEBUG] Output:                                 ^
[DEBUG] Output: ./source/static_6lowpan_config.h:12:37: error: use of undeclared identifier 'MBED_CONF_APP_TLS_PSK_KEY'
[DEBUG] Output: static const char tls_psk_key[16] = MBED_CONF_APP_TLS_PSK_KEY;
[DEBUG] Output:                                     ^
[DEBUG] Output: ./source/static_6lowpan_config.h:19:26: error: use of undeclared identifier 'MBED_CONF_APP_PSK_KEY_ID'
[DEBUG] Output:     {"PSK_KEY_ID", NULL, MBED_CONF_APP_PSK_KEY_ID},
[DEBUG] Output:                          ^
[DEBUG] Output: ./source/static_6lowpan_config.h:20:22: error: use of undeclared identifier 'MBED_CONF_APP_PAN_ID'
[DEBUG] Output:     {"PAN_ID", NULL, MBED_CONF_APP_PAN_ID},
[DEBUG] Output:                      ^
[DEBUG] Output: ./source/static_6lowpan_config.h:26:26: error: use of undeclared identifier 'MBED_CONF_APP_RF_CHANNEL'
[DEBUG] Output:     {"RF_CHANNEL", NULL, MBED_CONF_APP_RF_CHANNEL},
[DEBUG] Output:                          ^
[DEBUG] Output: ./source/static_6lowpan_config.h:27:31: error: use of undeclared identifier 'MBED_CONF_APP_RF_CHANNEL_PAGE'
[DEBUG] Output:     {"RF_CHANNEL_PAGE", NULL, MBED_CONF_APP_RF_CHANNEL_PAGE},
[DEBUG] Output:                               ^
[DEBUG] Output: ./source/static_6lowpan_config.h:28:31: error: use of undeclared identifier 'MBED_CONF_APP_RF_CHANNEL_MASK'
[DEBUG] Output:     {"RF_CHANNEL_MASK", NULL, MBED_CONF_APP_RF_CHANNEL_MASK},
[DEBUG] Output:                               ^
[DEBUG] Output: ./source/static_6lowpan_config.h:29:31: error: use of undeclared identifier 'MBED_CONF_APP_RPL_INSTANCE_ID'
[DEBUG] Output:     {"RPL_INSTANCE_ID", NULL, MBED_CONF_APP_RPL_INSTANCE_ID},
[DEBUG] Output:                               ^
[DEBUG] Output: ./source/static_6lowpan_config.h:30:30: error: use of undeclared identifier 'MBED_CONF_APP_RPL_IDOUBLINGS'
[DEBUG] Output:     {"RPL_IDOUBLINGS", NULL, MBED_CONF_APP_RPL_IDOUBLINGS},
[DEBUG] Output:                              ^
[DEBUG] Output: ./source/static_6lowpan_config.h:31:21: error: use of undeclared identifier 'MBED_CONF_APP_RPL_K'
[DEBUG] Output:     {"RPL_K", NULL, MBED_CONF_APP_RPL_K},
[DEBUG] Output:                     ^
[DEBUG] Output: ./source/static_6lowpan_config.h:32:32: error: use of undeclared identifier 'MBED_CONF_APP_RPL_MAX_RANK_INC'
[DEBUG] Output:     {"RPL_MAX_RANK_INC", NULL, MBED_CONF_APP_RPL_MAX_RANK_INC},
[DEBUG] Output:                                ^
[DEBUG] Output: ./source/static_6lowpan_config.h:33:36: error: use of undeclared identifier 'MBED_CONF_APP_RPL_MIN_HOP_RANK_INC'
[DEBUG] Output:     {"RPL_MIN_HOP_RANK_INC", NULL, MBED_CONF_APP_RPL_MIN_HOP_RANK_INC},
[DEBUG] Output:                                    ^
[DEBUG] Output: ./source/static_6lowpan_config.h:34:24: error: use of undeclared identifier 'MBED_CONF_APP_RPL_IMIN'
[DEBUG] Output:     {"RPL_IMIN", NULL, MBED_CONF_APP_RPL_IMIN},
[DEBUG] Output:                        ^
[DEBUG] Output: ./source/static_6lowpan_config.h:35:36: error: use of undeclared identifier 'MBED_CONF_APP_RPL_DEFAULT_LIFETIME'
[DEBUG] Output:     {"RPL_DEFAULT_LIFETIME", NULL, MBED_CONF_APP_RPL_DEFAULT_LIFETIME},
[DEBUG] Output:                                    ^
[DEBUG] Output: ./source/static_6lowpan_config.h:36:33: error: use of undeclared identifier 'MBED_CONF_APP_RPL_LIFETIME_UNIT'
[DEBUG] Output:     {"RPL_LIFETIME_UNIT", NULL, MBED_CONF_APP_RPL_LIFETIME_UNIT},
[DEBUG] Output:                                 ^
[DEBUG] Output: ./source/static_6lowpan_config.h:37:23: error: use of undeclared identifier 'MBED_CONF_APP_RPL_PCS'
[DEBUG] Output:     {"RPL_PCS", NULL, MBED_CONF_APP_RPL_PCS},
[DEBUG] Output:                       ^
[DEBUG] Output: ./source/static_6lowpan_config.h:38:23: error: use of undeclared identifier 'MBED_CONF_APP_RPL_OCP'
[DEBUG] Output:     {"RPL_OCP", NULL, MBED_CONF_APP_RPL_OCP},
[DEBUG] Output:                       ^
[DEBUG] Output: ./source/static_6lowpan_config.h:39:34: error: use of undeclared identifier 'MBED_CONF_APP_RA_ROUTER_LIFETIME'
[DEBUG] Output:     {"RA_ROUTER_LIFETIME", NULL, MBED_CONF_APP_RA_ROUTER_LIFETIME},
[DEBUG] Output:                                  ^
[DEBUG] Output: ./source/static_6lowpan_config.h:40:34: error: use of undeclared identifier 'MBED_CONF_APP_BEACON_PROTOCOL_ID'
[DEBUG] Output:     {"BEACON_PROTOCOL_ID", NULL, MBED_CONF_APP_BEACON_PROTOCOL_ID},
[DEBUG] Output:                                  ^
[DEBUG] Output: fatal error: too many errors emitted, stopping now [-ferror-limit=]

Pull request has been modified.

VeijoPesonen · 2020-01-24T11:50:54Z

I'm not sure are these related but I'm seeing following things in the logs:

K66F failure

log URL:

[Fatal Error] SFDP.cpp@25,10: mbed_trace.h: No such file or directory
[ERROR] ./mbed-os/drivers/source/SFDP.cpp:25:10: fatal error: mbed_trace.h: No such file or directory
   25 | #include "mbed_trace.h"
      |          ^~~~~~~~~~~~~~
compilation terminated.

Passed Example Compilation:
+--------------------------------+--------+-----------+----------+--------------+
| EXAMPLE NAME                   | TARGET | TOOLCHAIN | TEST GEN | BUILD RESULT |
+--------------------------------+--------+-----------+----------+--------------+
| mbed-os-example-blinky         |  K66F  |  GCC_ARM  | TEST_OFF |    PASSED    |
| mbed-os-example-tls/benchmark  |  K66F  |  GCC_ARM  | TEST_ON  |    PASSED    |
| mbed-os-example-tls/tls-client |  K66F  |  GCC_ARM  | TEST_ON  |    PASSED    |
| mbed-os-example-tls/hashing    |  K66F  |  GCC_ARM  | TEST_ON  |    PASSED    |
| mbed-os-example-tls/authcrypt  |  K66F  |  GCC_ARM  | TEST_ON  |    PASSED    |
| mbed-os-example-sockets        |  K66F  |  GCC_ARM  | TEST_ON  |    PASSED    |
| nanostack-border-router        |  K66F  |  GCC_ARM  | TEST_OFF |    PASSED    |
| mbed-os-example-mesh-minimal   |  K66F  |  GCC_ARM  | TEST_OFF |    PASSED    |
| mbed-os-example-attestation    |  K66F  |  GCC_ARM  | TEST_ON  |    PASSED    |
+--------------------------------+--------+-----------+----------+--------------+


Failed Example Compilation:
+----------------------------------+--------+-----------+----------+--------------+
| EXAMPLE NAME                     | TARGET | TOOLCHAIN | TEST GEN | BUILD RESULT |
+----------------------------------+--------+-----------+----------+--------------+
| mbed-os-example-blinky-baremetal |  K66F  |  GCC_ARM  |  UNSET   |    FAILED    |
+----------------------------------+--------+-----------+----------+--------------+

Passed Example Compilation:
+----------------------------------+--------+-----------+----------+--------------+
| EXAMPLE NAME                     | TARGET | TOOLCHAIN | TEST GEN | BUILD RESULT |
+----------------------------------+--------+-----------+----------+--------------+
| mbed-os-example-blinky           |  K66F  |  GCC_ARM  | TEST_OFF |    PASSED    |
| mbed-os-example-blinky-baremetal |  K66F  |  GCC_ARM  | TEST_OFF |    PASSED    |
| mbed-os-example-tls/benchmark    |  K66F  |  GCC_ARM  | NO_IMAGE |    PASSED    |
| mbed-os-example-tls/tls-client   |  K66F  |  GCC_ARM  | NO_IMAGE |    PASSED    |
| mbed-os-example-tls/hashing      |  K66F  |  GCC_ARM  | NO_IMAGE |    PASSED    |
| mbed-os-example-tls/authcrypt    |  K66F  |  GCC_ARM  | NO_IMAGE |    PASSED    |
| mbed-os-example-sockets          |  K66F  |  GCC_ARM  | NO_IMAGE |    PASSED    |
| mbed-os-example-attestation      |  K66F  |  GCC_ARM  | NO_IMAGE |    PASSED    |
+----------------------------------+--------+-----------+----------+--------------+


Failed Example Compilation:
+------------------------------+--------+-----------+----------+--------------+
| EXAMPLE NAME                 | TARGET | TOOLCHAIN | TEST GEN | BUILD RESULT |
+------------------------------+--------+-----------+----------+--------------+
| nanostack-border-router      |  K66F  |  GCC_ARM  |  UNSET   |    FAILED    |
| mbed-os-example-mesh-minimal |  K66F  |  GCC_ARM  |  UNSET   |    FAILED    |
+------------------------------+--------+-----------+----------+--------------+

@adbridge would you please restart the tests to see if compilation error with mbed-os-example-blinky-baremetal has some kind of trickle-down effect which causes failures elsewhere.

adbridge · 2020-01-24T12:03:03Z

Re starting ci to see if there is a real issue

mbed-ci · 2020-01-24T14:50:54Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

kjbracey · 2020-01-27T08:03:24Z

Examples test appears to be running twice - first with

python -u ../mbed-os/tools/test/examples/examples.py compile GCC_ARM --mcu K66F --profiles develop mbed-os/tools/profiles/extensions/minimal-printf.json

then a second time exactly the same command but with -v at the end. Because there was a failure the first time?

Here, and also in my PR #12142 (run 3), the re-run with -v fails with the missing MBED_CONF errors. The first run shows the real error.

Reason unknown - the -v flag doesn't seem like it should be triggering it. Maybe it's just the second run in the same workspace?

VeijoPesonen · 2020-01-28T08:26:03Z

@adbridge, @kjbracey-arm, @SeppoTakalo From my point of view this PR is ready and could be merged in.

michalpasztamobica

Aside from tiny documentation improvement request I have one larger question. @VeijoPesonen , have you considered adding the header parsing to BlockDevice class, so that both subclasses can inherit it, instead of adding separate global functions which need to be befriended with the modules using them?

drivers/internal/SFDP.h

VeijoPesonen · 2020-01-28T12:53:12Z

Aside from tiny documentation improvement request I have one larger question. @VeijoPesonen , have you considered adding the header parsing to BlockDevice class, so that both subclasses can inherit it, instead of adding separate global functions which need to be befriended with the modules using them?

Haven't really thought about it but is SFDP even logically part of BlockDevice class? I would say it isn't because not all BlockDevices do use SFDP.

michalpasztamobica

From my point of view this is OK. Doxygen changes to be added in another PR and I accept the logical explanation of why we can't embed SPDF parser into BlockDevice class.

VeijoPesonen · 2020-01-31T07:15:25Z

@kjbracey-arm, @SeppoTakalo This PR is ready and should be merged.

VeijoPesonen · 2020-02-04T12:47:46Z

@0xc0170 This one should be ready to go in.

0xc0170 · 2020-02-05T12:51:28Z

@VeijoPesonen Thanks for the reminder. I restarted CI to get the latest run, will be merged asap it completes

mbed-ci · 2020-02-05T15:39:20Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

Veijo Pesonen added 2 commits January 16, 2020 13:00

BUGFIX: SFDP Sector Map Parameter Header detection

80f87e3

The Sector Map Function Specific Table is assigned the ID LSB of 81 in hexadecimal, not in decimal[1]. [1] JESD216.01 p. 53

SFDP: lists unknown headers on Q/SPIF debug prints

ad43f23

ciarmcom requested review from SeppoTakalo and a team January 16, 2020 16:00

ciarmcom added the needs: review label Jan 16, 2020

0xc0170 added needs: work and removed needs: review labels Jan 17, 2020

Veijo Pesonen added 2 commits January 17, 2020 14:43

SFDP: splits header parsing to its own file

cefae90

SFDP logic is the same between SPIF and QSIP.

SFDP: All the headers are same length

58421ef

0xc0170 added needs: review and removed needs: work labels Jan 17, 2020

0xc0170 previously approved these changes Jan 20, 2020

View reviewed changes

Veijo Pesonen added 3 commits January 20, 2020 12:53

SFDP: Improves code's comment-sections

a7e97ef

SFDP: replaces statix fx with usage of anon namespace

aa59941

Q/SPIFBlockDevice: Separates SFDP Header retrieval

6bd3933

Separates SFDP header retrieval and moves it as a part of the earlier introduced SFDP file. Purpose is to abstract away differences between SPIF and QSPIF devices when it comes to fetching the SFDP headers from a device.

mergify bot added needs: CI and removed needs: review labels Jan 20, 2020

SeppoTakalo previously approved these changes Jan 21, 2020

View reviewed changes

adbridge added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Jan 21, 2020

mergify bot added needs: work and removed needs: CI labels Jan 21, 2020

VeijoPesonen mentioned this pull request Jan 28, 2020

SFDP: Move Sector Map Parameter Table parsing under SFDP module #12318

Merged

michalpasztamobica reviewed Jan 28, 2020

View reviewed changes

drivers/internal/SFDP.h Show resolved Hide resolved

michalpasztamobica approved these changes Jan 28, 2020

View reviewed changes

SeppoTakalo approved these changes Jan 31, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Feb 5, 2020

mergify bot added ready for merge and removed needs: CI labels Feb 5, 2020

0xc0170 added needs: CI and removed ready for merge labels Feb 5, 2020

mergify bot added ready for merge and removed needs: CI labels Feb 5, 2020

0xc0170 merged commit 952799c into ARMmbed:master Feb 6, 2020

mergify bot removed the ready for merge label Feb 6, 2020

VeijoPesonen deleted the bugfix_sfdp_parse_sfdp_headers branch February 6, 2020 12:24

VeijoPesonen mentioned this pull request Feb 14, 2020

SFDP: consolidation of SFDP parsing [2/5] #12426

Merged

This was referenced Mar 2, 2020

STM32 : enable MBED trace for QSPI #12451

Merged

Issues with SFDP parsing of the Sector Map Parameter Header and Table parsing #11722

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81 #12270

BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81 #12270

VeijoPesonen commented Jan 16, 2020 •

edited

Loading

ciarmcom commented Jan 16, 2020

0xc0170 commented Jan 17, 2020

VeijoPesonen commented Jan 17, 2020

adbridge commented Jan 20, 2020

adbridge commented Jan 21, 2020

mbed-ci commented Jan 21, 2020

VeijoPesonen commented Jan 22, 2020 •

edited

Loading

VeijoPesonen commented Jan 24, 2020

adbridge commented Jan 24, 2020

mbed-ci commented Jan 24, 2020

kjbracey commented Jan 27, 2020

VeijoPesonen commented Jan 28, 2020

michalpasztamobica left a comment

VeijoPesonen commented Jan 28, 2020

michalpasztamobica left a comment

VeijoPesonen commented Jan 31, 2020

VeijoPesonen commented Feb 4, 2020

0xc0170 commented Feb 5, 2020

mbed-ci commented Feb 5, 2020

BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81 #12270

BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81 #12270

Conversation

VeijoPesonen commented Jan 16, 2020 • edited Loading

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

SPIF compilation

QSPIF compilation

Reviewers

ciarmcom commented Jan 16, 2020

0xc0170 commented Jan 17, 2020

VeijoPesonen commented Jan 17, 2020

adbridge commented Jan 20, 2020

adbridge commented Jan 21, 2020

mbed-ci commented Jan 21, 2020

Test run: FAILED

VeijoPesonen commented Jan 22, 2020 • edited Loading

One of the issues

VeijoPesonen commented Jan 24, 2020

K66F failure

adbridge commented Jan 24, 2020

mbed-ci commented Jan 24, 2020

Test run: SUCCESS

kjbracey commented Jan 27, 2020

VeijoPesonen commented Jan 28, 2020

michalpasztamobica left a comment

Choose a reason for hiding this comment

VeijoPesonen commented Jan 28, 2020

michalpasztamobica left a comment

Choose a reason for hiding this comment

VeijoPesonen commented Jan 31, 2020

VeijoPesonen commented Feb 4, 2020

0xc0170 commented Feb 5, 2020

mbed-ci commented Feb 5, 2020

Test run: SUCCESS

VeijoPesonen commented Jan 16, 2020 •

edited

Loading

VeijoPesonen commented Jan 22, 2020 •

edited

Loading