Fix to sending IPV6 UPD packet fails IPv6 enabled in SoftAP intf #12312
Conversation
|
@cy-arsm, thank you for your changes. |
|
@AnttiKauppila @0xc0170 - For review. We need this fix is needed for our release, hence we need this fix in mbed-os 5.15.1 release. Thanks. |
| @@ -355,6 +355,15 @@ nsapi_error_t WhdSTAInterface::disconnect() | |||
| } | |||
| whd_emac_wifi_link_state_changed(_whd_emac.ifp, WHD_FALSE); | |||
|
|
|||
| // remove the interface added in connect | |||
| if (_interface) { | |||
There was a problem hiding this comment.
it seems like this would prevent ever connecting again.
There was a problem hiding this comment.
@morser499 , local private member _interface is updated with the interface details in add_ehternet_interface()API call.
Hence _interface is updated to NULL inside remove_ethernet_interface()API call.
As part of connect interface is updated and as part of disconnect interface is removed. Hence reconnecting is not blocked.
There was a problem hiding this comment.
Have verified multiple time's connect -> disconnect -> connect to ensure re-connection is successful.
Issue: udp_sendto() Fails for multicast IPV6 packet when interface is switched from SoftAP to STA mode. When SoftAP start is called, add_ethernet_interface() will be called internally to add interface details into netif_list. When switching from SoftAP to STA mode, add_ethernet_interface() will be called again to append the interace details into netif_list. When udp_sendto() is called, ip6_route() will return interface as NULL since it consider device as single interface. Fix: SoftAP mode Stop, call remove_ethernet_interface() to remove the interface from the netif_list.
|
@maclobdell - This change is required in mbed-os 5.15.1. Can you get this change reviewed and merged for 5.15.1. Thanks |
|
Isn't this a Feature update as you are adding new function to APIs? |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Looks like it is! It is ready for merging, the version will be checked. cc @bulislaw |
|
That is a new feature, so it shouldn't go to a patch release. |
|
@bulislaw, I am not certain that is correct. The SoftAP feature from WhdSoftAPInterface.cpp has existed for a number of releases and IPV6 multicast pre-exists this as well. In this case, there is a defect where when you are using both together, you can have a failure. This PR fixes that defect. It doesn't introduce a new feature per-se. Thoughts? Ian |
adbridge
added
release-version: 6.0.0-alpha-2
|
@adbridge , please exclude this PR from all releases. We are working on an additional PR that fixes issues introduced in this one. Thank you, Ian |
|
@ifyall unfortunately this has already made it to alpha-2 (currently being released) but these are only pre-releases for 6.0 and not for general usage anyway. Also as our releases come off master now and this one was merged 16 days ago it could be troublesome to back out. |
|
@adbridge OK, thank you. |
|
@ifyall would you like to raise a PR against master to back this out in readiness for the next pre-release or do you propose to just land additional PRs with fixes on top of this one ? |
…evert Reverting #12312 as it breaking current WiFI connect()->Disconnect() sequence
Modified LwIP mbed-os wrapper LWIPInterface.cpp to add an api remove interface which will be called as part of WhdSoftAPInterface::stop() to support sending UDP IPv6 packet is sent over link-local interface
Issue: udp_sendto() Fails for multicast IPV6 packet when interface is switched from SoftAP to STA mode.
When SoftAP start is called, add_ethernet_interface() will be called internally to add interface details into netif_list.
When switching from SoftAP to STA mode, add_ethernet_interface() will be called again to append the interace details into netif_list.
When udp_sendto() is called, ip6_route() will return interface as NULL since it consider device as single interface.
Summary of changes
LWIPInterface.cpp
LWIP::remove_ethernet_interface() api is added to remove the interface from the netif_list.
WhdSoftAPInterface.cpp
WhdSoftAPInterface::stop(), calling remove_ethernet_interface() from the network list which was added as part of WhdSoftAPInterface::start()
WhdSTAInterface.cpp
WhdSTAInterface::stop(), calling remove_ethernet_interface() from the network list which was added as part of WhdSTAInterface::start()
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers