Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AT_CellularStack: crash during TCP test #12329

Merged
merged 1 commit into from
Feb 3, 2020
Merged

AT_CellularStack: crash during TCP test #12329

merged 1 commit into from
Feb 3, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Got crash during TCP test with BG96 STMOD_CELLULAR

Analysis shows that function tries to access _socket[1] which is not opened in this case

@AriParkkila

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant
AT_CellularStack: crash during TCP test
a1fb286 
function tries to access _socket[1] whch is not opened
@ciarmcom ciarmcom requested review from a team January 29, 2020 16:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 3, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 3, 2020
@0xc0170 0xc0170 merged commit 5863415 into ARMmbed:master Feb 3, 2020
@mergify mergify bot removed the ready for merge label Feb 3, 2020
@jeromecoutant jeromecoutant deleted the PR_ATCELL branch February 4, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @bulislaw @AnttiKauppila @AriParkkila