Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HANI_IOT: add new target board support #12355

Merged
merged 4 commits into from
Feb 4, 2020
Merged

HANI_IOT: add new target board support #12355

merged 4 commits into from
Feb 4, 2020

Conversation

panmasuo
Copy link
Contributor

@panmasuo panmasuo commented Feb 3, 2020

Summary of changes

Added support for new board HANI_IOT based on NXP's LPC55S69. Config based on LPC55S60_NS/LPCXpresso board + SPIF support.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

HANI_IOT - ARMC6 report
HANI_IOT - IAR report
HANI_IOT - GCC_ARM report + HANI_IOT - GCC_ARM ticker test suite (something happened during testing and ticker test suite time-outed; did rerun for ticker and result is OK)

Reviewers

@MarceloSalazar

@ciarmcom
Copy link
Member

ciarmcom commented Feb 3, 2020

@panmasuo, thank you for your changes.
@maclobdell @MarceloSalazar @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage please review.

adbridge
adbridge previously requested changes Feb 3, 2020
View reviewed changes
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/PeripheralNames.h Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/PeripheralPinMaps.h Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/PeripheralPins.c Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/PinNames.h Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/clock_config.c Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/clock_config.h Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/device.h Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/device.h Outdated Show resolved Hide resolved
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/mbed_overrides.c Outdated Show resolved Hide resolved
@mergify mergify bot dismissed adbridge’s stale review February 3, 2020 14:29

Pull request has been modified.

0xc0170
0xc0170 previously requested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one license request (all new files), otherwise LGTM

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_HANI_IOT/PeripheralNames.h Show resolved Hide resolved
@mergify mergify bot dismissed 0xc0170’s stale review February 3, 2020 14:56

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

CI was started

@mbed-ci
Copy link

mbed-ci commented Feb 3, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit c63daa5 into ARMmbed:master Feb 4, 2020
@mergify mergify bot removed the ready for merge label Feb 4, 2020
@panmasuo panmasuo deleted the hani_iot_new_target branch February 4, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@adbridge adbridge adbridge left review comments

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.15.1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@panmasuo @ciarmcom @0xc0170 @mbed-ci @MarceloSalazar @SeppoTakalo @adbridge @pan-pawel2