Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated ethernet APIs #12500

Merged
merged 1 commit into from Feb 27, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Feb 24, 2020

Summary of changes

The Ethernet is no longer supported, so removed header and cpp files and its dependency.

Impact of changes

Breaking change: The Ethernet object is removed as it has been deprecated in the previous feature releases.

Migration actions required

Use NetworkInterface instead, for more details have a look at our documentation here

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @bulislaw


@rajkan01 rajkan01 changed the title Removed deprecated Ethernet APIs Removed the deprecated Ethernet APIs Feb 24, 2020
@rajkan01 rajkan01 changed the title Removed the deprecated Ethernet APIs Remove the deprecated Ethernet APIs Feb 24, 2020
@rajkan01 rajkan01 changed the title Remove the deprecated Ethernet APIs Remove the deprecated ethernet APIs Feb 24, 2020
@ciarmcom ciarmcom requested review from bulislaw, evedon and a team February 24, 2020 14:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@bulislaw @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@kjbracey
Copy link
Contributor

The corresponding HAL header ethernet_api.h should also go.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

The corresponding HAL header ethernet_api.h should also go.

Can you add this one as well?

@rajkan01
Copy link
Contributor Author

The corresponding HAL header ethernet_api.h should also go.

Can you add this one as well?

@0xc0170 We will do once started working on HAL folder.

@bulislaw
Copy link
Member

Could we also link to our handbook: Use NetworkInterface instead, for more details have a look at our documentation here......

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnotherButler Note that the Eternet API needs to be removed from the docs.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Feb 26, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 26, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

Client restarted

@AnotherButler
Copy link
Contributor

Does EthInterface documentation still stay? https://os.mbed.com/docs/mbed-os/v5.15/apis/ethernet.html

@kjbracey
Copy link
Contributor

Yes, that documents the current API. I don't think the one being removed here is in the docs. It's never been used in Mbed OS 5, it's a 2/classic remnant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants