allow reconfiguring a running watchdog

[paul-szczepanek-arm]

Summary of changes

Calling Watchdog::start is limited to only configuring a stopped watchdog. There is no need for such a restriction. The driver checks an internal state and disallows the call. The ports allow configuring a running watchdog. If a port does not allow such a call the call will return an error. No need to preemptively disallow it. The hal call specifies the call can made repeatedly without stopping.

Impact of changes

Migration actions required

Documentation

The docs are already correct as they don't mention any requirement for watchdog to be stopped. This fix will bring the actual behaviour in line with them.

---

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

@bulislaw

[bulislaw]

Looks good, but I think we need to clarify the docs a bit:

    /** Start the Watchdog timer.
     *
     * @note Asset that the timeout param is supported by the target
     * (0 < timeout <= Watchdog::get_max_timeout).
     *
     * @param timeout Watchdog timeout in milliseconds.
     *
     * @return true if the Watchdog timer was started successfully;
     *         false if Watchdog timer was not started or if the Watchdog
     *         timer is already running.
     */
    bool start(uint32_t timeout);

fore return False if Watchdog timer was not started or if the Watchdog timer is already running. Should probably say that it's false when the timer wasn't started or it setting new timeout wasn't possible.

Pull request has been modified.

[0xc0170]

Ci started

[mbed-ci]

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_unittests

[0xc0170]

@paul-szczepanek-arm Unittest failed for Watchdog - please review

[paul-szczepanek-arm]

looks like the unit test is testing the assumption that I'm trying to remove

[0xc0170]

In that case, fix the unit test as well and document the behavior (already done here).

Pull request has been modified.

[paul-szczepanek-arm]

removed the part of the test that tests that assumption

[0xc0170]

CI restarted

[mbed-ci]

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 2
Build artifacts