Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct doxygen for Mail::get #12617

Merged
merged 1 commit into from Mar 16, 2020
Merged

Conversation

evedon
Copy link
Contributor

@evedon evedon commented Mar 11, 2020

Summary of changes

Corrected doxygen for Mail::get.

Impact of changes

Fixes ARMmbed/mbed-os-5-docs/issues/1234

Migration actions required

N/A

Documentation

N/A


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team March 11, 2020 18:00
@ciarmcom
Copy link
Member

@evedon, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 12, 2020
@adbridge
Copy link
Contributor

@evedon how have you verified that this does indeed fix the Doxygen errors ?

@adbridge
Copy link
Contributor

CI started

@evedon
Copy link
Contributor Author

evedon commented Mar 12, 2020

@evedon how have you verified that this does indeed fix the Doxygen errors ?

I haven't run doxygen. What was wrong was the content not the rendering.

@mergify mergify bot added needs: work and removed needs: CI labels Mar 12, 2020
@evedon
Copy link
Contributor Author

evedon commented Mar 12, 2020

CI Issue is unrelated to the documentation change.

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2020

Client restarted

@0xc0170 0xc0170 merged commit eb07229 into ARMmbed:master Mar 16, 2020
@mergify mergify bot removed the ready for merge label Mar 16, 2020
@evedon evedon deleted the ed-doxygen-mail branch March 26, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value of Mail#get() method is incorrect
5 participants