Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated ethernet hal APIs #12639

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Mar 17, 2020

Summary of changes

Removed ethernet hal deprecated APIs.

Impact of changes

Breaking change: The Ethernet hal APIs are removed as they have been deprecated in a previous Mbed OS release.

Migration actions required

  • EthInterface is now the preferred way to get an Ethernet object.
  • Alternatively, use NetworkInterface to get an instance of an appropriate network interface (WiFi or Ethernet).

Documentation

None.


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon , @maclobdell @SeppoTakalo


@rajkan01 rajkan01 force-pushed the ethernethal_remove_deprecated branch from 9a89f1c to 9f9e5cc Compare March 17, 2020 12:58
@rajkan01 rajkan01 force-pushed the ethernethal_remove_deprecated branch from 9f9e5cc to 20c3e38 Compare March 17, 2020 13:00
@rajkan01
Copy link
Contributor Author

@toyowata As part of this PR, we have removed the ethernet hal APIs but noticed that netscoket emac driver is using these deprecated APIs, Please raise this issue with Renesas to fix.

@rajkan01 rajkan01 changed the title Remove the deprecated ethernet APIs Remove the deprecated ethernet hal APIs Mar 17, 2020
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@toyowata @maclobdell @ashok-rao @evedon @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@toyowata
Copy link
Contributor

@rajkan01 thanks for letting know this. I asked @ARMmbed/team-renesas-rz to fix their emac driver.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 18, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 18, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 18, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 18, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

Still there are references in the code, please review failures

@rajkan01
Copy link
Contributor Author

rajkan01 commented Mar 19, 2020

Still there are references in the code, please review failures
@0xc0170 We have already raised the issue to Renesas to fix emac driver refer #12639 (comment)

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

Set this as preceding PR (driver in renesas needs to be fixed)

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2020

I cleaned up pr-merge outdated hook.

Once approved by @bulislaw , will go in.

@0xc0170 0xc0170 merged commit 6e46e2d into ARMmbed:master Apr 1, 2020
@mergify mergify bot removed the ready for merge label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants