Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests-integration-fs-threaded: makes tests independent from each other #12668

Merged
merged 2 commits into from
Apr 9, 2020
Merged

tests-integration-fs-threaded: makes tests independent from each other #12668

merged 2 commits into from
Apr 9, 2020

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Mar 23, 2020 •
edited
Loading

Summary of changes

Depends on the PR #12658[merged] . This PR makes the test cases independent from each other to avoid out-of-storage-space-issues. The work was started because of a PR #11451 but this won't solve the issue seen with CY8CKIT_062_WIFI_BT.
A new regression test case was created to reveal the issue which was earlier exposed by two intervening test cases.
FatFileSystem is not used for testing anymore - LittleFileSystem is preferred.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@SeppoTakalo
@jarlamsa
@maclobdell
@kyle-cypress

@mergify mergify bot added the needs: work label Mar 23, 2020
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @maclobdell @kyle-cypress @jarlamsa @ARMmbed/mbed-os-maintainers please review.

@VeijoPesonen VeijoPesonen mentioned this pull request Mar 23, 2020
Closed
@0xc0170 0xc0170 added this to To do in Pull request triage Mar 25, 2020
@0xc0170 0xc0170 moved this from needs: review to needs: work in Pull request triage Mar 25, 2020
@VeijoPesonen
Copy link
Contributor Author

Please re-review.

SeppoTakalo
SeppoTakalo previously approved these changes Mar 30, 2020
View reviewed changes
@mbed-ci
Copy link

mbed-ci commented Mar 30, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

@VeijoPesonen Please review astyle failures

@mergify mergify bot dismissed SeppoTakalo’s stale review March 30, 2020 14:49

Pull request has been modified.

@VeijoPesonen
Copy link
Contributor Author

astyle fixes done.

SeppoTakalo
SeppoTakalo previously approved these changes Mar 31, 2020
View reviewed changes
@mergify
Copy link

mergify bot commented Mar 31, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: CI label Mar 31, 2020
maclobdell
maclobdell previously approved these changes Mar 31, 2020
View reviewed changes
@mergify mergify bot dismissed stale reviews from SeppoTakalo and maclobdell March 31, 2020 15:21

Pull request has been modified.

Veijo Pesonen added 2 commits March 31, 2020 18:42
tests-integration-fs: makes tests independent
7d2f005 
Cleans up the created files between test cases to avoid out of space
situations.
tests-integration-fs: CY8CPROTO_062_4343W regression
61d70ae 
Created a new test case to reveal an issue with CY8CPROTO_062_4343W
which was earlier exposed by two intervening test cases.
@VeijoPesonen
Copy link
Contributor Author

Created unfortunately a merge commit to resolve conflicts, fixed and rebased.

@mergify mergify bot added needs: CI and removed needs: work labels Apr 3, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 3, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Apr 3, 2020
@VeijoPesonen
Copy link
Contributor Author

@0xc0170 The tests changed here are not part of PR or nightly tests so issues seen are unrelated.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2020

@VeijoPesonen Correct, sd card started failing on Friday. @jamesbeyond was looking at it

There are known issues in CI (2 of them are reported here in github) and are blocking all PRs 😢

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 8, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 0aacbf7 into ARMmbed:master Apr 9, 2020
@mergify mergify bot removed the ready for merge label Apr 9, 2020
@VeijoPesonen VeijoPesonen deleted the fix_tests-integration-fs_2 branch April 9, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-cypress kyle-cypress kyle-cypress requested changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@maclobdell maclobdell maclobdell left review comments

@jarlamsa jarlamsa Awaiting requested review from jarlamsa

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
No open projects
Pull request triage
  
needs: work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@VeijoPesonen @ciarmcom @mbed-ci @0xc0170 @SeppoTakalo @maclobdell @kyle-cypress