Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ARMC5 reference from mbed compile -S output #12672

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Remove deprecated ARMC5 reference from mbed compile -S output #12672

merged 1 commit into from
Mar 25, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Mar 23, 2020 •
edited
Loading

Summary of changes

Removed deprecated ARMC5 reference from mbed compile -S command output.

Impact of changes

With these changes, mbed compile -S will not produce any ARMC5 reference.

Migration actions required

None.

Documentation

None.

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@ciarmcom ciarmcom requested review from evedon and a team March 23, 2020 16:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added this to Done in Pull request triage Mar 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

@ARMmbed/mbed-os-tools Please review, this can be merged once approved

@0xc0170 0xc0170 moved this from Ready for merge to needs: review in Pull request triage Mar 25, 2020
@0xc0170 0xc0170 merged commit 253e7be into ARMmbed:master Mar 25, 2020
@mergify mergify bot removed the ready for merge label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
No open projects
Pull request triage
  
needs: review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @mark-edgeworth @evedon