Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 EMAC : remove TIMEOUT issue when cable is not plugged yet #12686

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

This fixes #12577

ST Ethernet river implementation is not very well implemented...
Init procedure needs Ethernet cable to be plugged in order to return OK!
Workaround is then to not return this error case to higher layer in this case.

@LMESTM
@JojoS62
@artokin

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@JojoS62
Copy link
Contributor

JojoS62 commented Mar 24, 2020

I can test this soon.

@ciarmcom ciarmcom requested review from a team March 24, 2020 12:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

CI started

@0xc0170 0xc0170 requested a review from artokin March 24, 2020 12:25
@mergify mergify bot added needs: CI and removed needs: review labels Mar 24, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 24, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added this to Done in Pull request triage Mar 25, 2020
@0xc0170 0xc0170 merged commit fff2342 into ARMmbed:master Mar 25, 2020
@mergify mergify bot removed the ready for merge label Mar 25, 2020
@jeromecoutant jeromecoutant deleted the PR_REVERT_ETHERNET branch March 27, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Pull request triage
  
Ready for merge
Development

Successfully merging this pull request may close these issues.

STM32 EMAC: Ethernet driver initialisation fails in DISCO_F769NI
6 participants