Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-client-cli: Remove support for ARM Compiler 5 #12705

Merged
merged 1 commit into from Mar 31, 2020
Merged

mbed-client-cli: Remove support for ARM Compiler 5 #12705

merged 1 commit into from Mar 31, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.

Impact of changes

Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.

Migration actions required

Use Arm Compiler 6.

Documentation

N/A

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@OPpuolitaival @evedon

@ciarmcom ciarmcom requested review from evedon, OPpuolitaival and a team March 26, 2020 12:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@OPpuolitaival @evedon @ARMmbed/mbed-os-maintainers please review.

OPpuolitaival
OPpuolitaival previously approved these changes Mar 26, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Mar 26, 2020
@teetak01
Copy link
Contributor

teetak01 commented Mar 26, 2020 •
edited

Nitpick: mbed-client is not mbed-client-cli. Two very different things. The title caught my attention.

former refers to the legacy mbed-client LwM2M library.
latter is generic command-line library for generic "client".

https://github.com/armmbed/mbed-client-cli

Maybe fix the title to mbed-client-cli

evedon
evedon previously approved these changes Mar 26, 2020
View reviewed changes
@hugueskamba hugueskamba changed the title mbed-client: Remove support for ARM Compiler 5 mbed-client-cli: Remove support for ARM Compiler 5 Mar 26, 2020
@hugueskamba
mbed-client-cli: Remove support for ARM Compiler 5
a79ae95 
ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.
@hugueskamba hugueskamba force-pushed the hk_remove_armc5_support_mbed-client branch from 7b1258f to a79ae95 Compare March 26, 2020 13:45
@mergify mergify bot dismissed stale reviews from OPpuolitaival and evedon March 26, 2020 13:46

Pull request has been modified.

@hugueskamba
Copy link
Collaborator Author

Nitpick: mbed-client is not mbed-client-cli. Two very different things. The title caught my attention.

former refers to the legacy mbed-client LwM2M library.
latter is generic command-line library for generic "client".

https://github.com/armmbed/mbed-client-cli

Thanks.
The PR title and commit have been amended.

@ciarmcom ciarmcom requested review from evedon, OPpuolitaival and a team March 26, 2020 14:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@OPpuolitaival @evedon @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot removed the needs: review label Mar 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

Test restarted

@0xc0170 0xc0170 merged commit 5d07fa8 into ARMmbed:master Mar 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

@Mergifyio backport mbed-os-5.15

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

Above is just a test of a bot, not really backporting anything

@mergify mergify bot removed the ready for merge label Mar 31, 2020
@mergify
Copy link

mergify bot commented Mar 31, 2020

Command backport mbed-os-5.15: success

Backports have been created

@mergify mergify bot mentioned this pull request Mar 31, 2020
Closed
@hugueskamba hugueskamba deleted the hk_remove_armc5_support_mbed-client branch June 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hugueskamba @ciarmcom @teetak01 @0xc0170 @mbed-ci @OPpuolitaival @evedon