Mbedtls fixes for 5.15.2 #12723

AnttiKauppila · 2020-03-31T05:28:14Z

Summary of changes

This is a preparation PR for upcoming MbedTLS optimisation changes.
In the commits there are mostly flagged out code and this must not break anything.

Impact of changes

Migration actions required

Documentation

None, optimisations will be documented in MbedTLS optimisation release

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@sbutcher-arm @jarvte @kivaisan

Unittests fixed 2 mbedtls functions were updated to reflect the api

AnttiKauppila · 2020-03-31T05:29:08Z

Same content as in #12479

ciarmcom · 2020-03-31T07:00:35Z

@AnttiKauppila, thank you for your changes.
@sbutcher-arm @jarvte @kivaisan @ARMmbed/mbed-os-maintainers please review.

adbridge

This has the same issues as the original PR on master. If there can be only 2 possible conditional code paths then we should be using

#if
#else
#endif

Rather than

#if
#elif
#endif

Pull request has been modified.

0xc0170 · 2020-04-03T08:13:44Z

Github states This branch is out-of-date with the base branch , so just rebase on top of 5.15 branch

I hope we get CI config fixed today to restart tests

adbridge · 2020-04-03T09:40:06Z

@adbridge against 5.15.0 or 5.15.1?
This is currently up to date with mbed-os-5.15

Hi @AnttiKauppila there is only one branch :) mbed-os-5.15 that is what PRs are raised against , not specific releases.

JanneKiiskila · 2020-04-03T10:30:19Z

Failures in CI, seem unrelated;

[1585843308.57][CONN][RXD] >>> Running case #15: 'WIFI-CONNECT'...
[1585843308.57][CONN][INF] found KV pair in stream: {{__testcase_start;WIFI-CONNECT}}, queued...
[1585843360.72][CONN][RXD] :37::FAIL: Expected 0 Was -3017
[1585843360.72][CONN][RXD] :38::FAIL: Expected 0 Was -3004
[1585843360.72][CONN][RXD] :40::FAIL: Expected 0 Was -3014
[1585843412.87][CONN][RXD] :41::FAIL: Expected 0 Was -3017
[1585843412.87][CONN][RXD] :42::FAIL: Expected 0 Was -3004
[1585843464.91][CONN][RXD] :47::FAIL: Expected 0 Was -3017
[1585843464.91][CONN][RXD] :48::FAIL: Expected 0 Was -3004
[1585843465.02][CONN][INF] found KV pair in stream: {{__testcase_finish;WIFI-CONNECT;0;7}}, queued...
[1585843465.12][CONN][RXD] >>> 'WIFI-CONNECT': 0 passed, 7 failed with reason 'Test Cases Failed'

And we are failing the examples, seems to me BLE is deprecated but we still do try it?

[2020-04-02T16:31:53.573Z] Switched to a new branch 'mbed-os-5.15'
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_BatteryLevel/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_Beacon/shields/TARGET_ST_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_Button/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_GAP/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_GAPButton/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_GattClient/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_GattServer/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_HeartRate/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_LED/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_LEDBlinker/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_Privacy/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_SM/shields/TARGET_CORDIO_BLUENRG.lib
[2020-04-02T16:31:53.573Z] D	deprecated/BLE_Thermometer/shields/TARGET_CORDIO_BLUENRG.lib

0xc0170 · 2020-04-03T10:32:20Z

There was a misconfig in CI :( A fix landed recently, will restart

mbed-ci · 2020-04-06T10:04:48Z

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test-lts

AnttiKauppila · 2020-04-06T13:13:41Z

@ARMmbed/mbed-os-maintainers Could you retrigger the tests?

0xc0170 · 2020-04-06T20:48:12Z

@ARMmbed/mbed-os-maintainers Could you retrigger the tests?

We were waiting for the fixes, will do now (but might still fail, need to wait for couple of jobs to complete to prove its all fine)

0xc0170 · 2020-04-06T20:48:27Z

CI restarted

mbed-ci · 2020-04-07T00:42:02Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test-lts

JanneKiiskila · 2020-04-07T06:35:43Z

Jenkins says; "Nice one! All 7645 tests for this pipeline are passing.".
However, GitHub seems to disagree?
@jamesbeyond @0xc0170

AnttiKauppila · 2020-04-07T06:53:23Z

@JanneKiiskila Check the Pipeline K66F + ESP8266 combo fails

AnttiKauppila · 2020-04-07T06:54:19Z

Fatal error: ... mbed-os-greentea_K66F-ESP8266_ARM.tar.gz" does not exist

0xc0170 · 2020-04-07T08:56:55Z

I'll restarted the test (we already have CI passing in other jobs, the config should be correct now)

0xc0170 · 2020-04-07T10:26:19Z

Restarting entire pipeline (looks like devices are not as in later jobs)

mbed-ci · 2020-04-07T14:27:36Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test-lts

0xc0170 · 2020-04-07T14:30:06Z

@AnttiKauppila @ARMmbed/mbed-os-test Failed with dns failure for one target, how can we fix this one (not related to this PR). Is this network related issue, code (target/test) is fine on 5.15 branch?

0xc0170 · 2020-04-07T14:33:32Z

We got internal ticket for tracking this, ONME-4498

0xc0170 · 2020-04-08T06:56:59Z

The latest restart overnight worked, ready to go in

Teppo Järvelin and others added 6 commits March 31, 2020 08:25

Prepare for upcoming MbedTLS changes

a325320

Added new global rng, needed for MbedTLS optimisations

163e5c9

fixed ssl hostname handling

c801caf

Added missing optimizations based on mbedtls/baremetal.h config

377e363

trace group defiined for shared_rng

af12d06

Unittests fixed 2 mbedtls functions were updated to reflect the api

MBEDTLS_SSL_EXPORT_KEYS added to Nanostack's tls_sec_prot_lib

3dbe97b

0xc0170 added the Release review required label Mar 31, 2020

ciarmcom requested review from jarvte, kivaisan, simonbutcher and a team March 31, 2020 07:00

ciarmcom added the needs: review label Mar 31, 2020

kivaisan approved these changes Mar 31, 2020

View reviewed changes

jarvte approved these changes Mar 31, 2020

View reviewed changes

adbridge previously requested changes Mar 31, 2020

View reviewed changes

AnttiKauppila closed this Mar 31, 2020

mergify bot added needs: work and removed needs: review Release review required needs: work labels Mar 31, 2020

more error handling added for ctr and hmac

5bdc731

AnttiKauppila reopened this Mar 31, 2020

mergify bot added the needs: work label Mar 31, 2020

Licence updated

9c32811

0xc0170 approved these changes Apr 2, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Apr 2, 2020

adbridge added release-version: 5.15.2 and removed Release review required labels Apr 3, 2020

mergify bot added ready for merge and removed needs: CI labels Apr 7, 2020

0xc0170 added mergify skip needs: CI and removed ready for merge labels Apr 7, 2020

0xc0170 added ready for merge and removed needs: CI labels Apr 8, 2020

0xc0170 merged commit 9929ddd into ARMmbed:mbed-os-5.15 Apr 8, 2020

mergify bot removed the ready for merge label Apr 8, 2020

0xc0170 removed the mergify skip label Apr 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mbedtls fixes for 5.15.2 #12723

Mbedtls fixes for 5.15.2 #12723

AnttiKauppila commented Mar 31, 2020

AnttiKauppila commented Mar 31, 2020

ciarmcom commented Mar 31, 2020

adbridge left a comment

0xc0170 commented Apr 3, 2020

adbridge commented Apr 3, 2020

JanneKiiskila commented Apr 3, 2020

0xc0170 commented Apr 3, 2020

mbed-ci commented Apr 6, 2020

AnttiKauppila commented Apr 6, 2020

0xc0170 commented Apr 6, 2020

0xc0170 commented Apr 6, 2020

mbed-ci commented Apr 7, 2020

JanneKiiskila commented Apr 7, 2020

AnttiKauppila commented Apr 7, 2020

AnttiKauppila commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

mbed-ci commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

0xc0170 commented Apr 8, 2020

Mbedtls fixes for 5.15.2 #12723

Mbedtls fixes for 5.15.2 #12723

Conversation

AnttiKauppila commented Mar 31, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

AnttiKauppila commented Mar 31, 2020

ciarmcom commented Mar 31, 2020

adbridge left a comment

Choose a reason for hiding this comment

0xc0170 commented Apr 3, 2020

adbridge commented Apr 3, 2020

JanneKiiskila commented Apr 3, 2020

0xc0170 commented Apr 3, 2020

mbed-ci commented Apr 6, 2020

Test run: FAILED

AnttiKauppila commented Apr 6, 2020

0xc0170 commented Apr 6, 2020

0xc0170 commented Apr 6, 2020

mbed-ci commented Apr 7, 2020

Test run: FAILED

JanneKiiskila commented Apr 7, 2020

AnttiKauppila commented Apr 7, 2020

AnttiKauppila commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

mbed-ci commented Apr 7, 2020

Test run: FAILED

0xc0170 commented Apr 7, 2020

0xc0170 commented Apr 7, 2020

0xc0170 commented Apr 8, 2020