-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PSA implementation for v8-M and dual CPU targets #12737
Conversation
@Patater, thank you for your changes. |
Please review tools failures in Travis:
|
abd2e02
to
5d9ea82
Compare
|
@Patater note we need to keep the NS targets as they're still valid and expect to be supported in Mbed 6. Possibly rename the targets assuming they don't break with mbed-ls and greentea tools
|
@@ -0,0 +1,16 @@ | |||
#! /usr/bin/env python | |||
# Copyright (c) 2019 ARM Limited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright year should be 2020
.
First rebased on latest master, with no other changes. Then, rebased again to edit the "psa: Remove v8-M S targets" commit to fix a path issue in |
CI started |
Test run: FAILEDSummary: 2 of 3 test jobs failed Failed test jobs:
|
Does this need CI update? It tries to build |
CI started with updated CI config |
Test run: FAILEDSummary: 2 of 3 test jobs failed Failed test jobs:
|
CI restarted |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Has this been addressed ? We are removing these completely (_S and _NS), not keeping anything in the tree? |
Got +1 from @andypowers, this is ready for integration |
Summary of changes
With Mbed 6, TrustedFirmware-M (TF-M) is the source of Mbed's implementation of PSA. This means Mbed 6 doesn't need to contain any code or tooling to build the v8-M or dual CPU secure binaries.
This patch set removes tooling, code, and targets that would have been used to make PSA secure binaries for v8-M or dual CPU platforms.
Impact of changes
ARM_MUSCA_A1_S
ARM_MUSCA_B1_S
LPC55S69_NS
LPC55S69_S
HANI_IOT
NU_PFM_M2351_NS
NU_PFM_M2351_S
Migration actions required
Use Mbed 5.15 if you require PSA targets with exporter support, or one of the removed targets. LPC55S69 and Numaker M2351 will be supported in Mbed 6 at a later date, after the targets are supported by TF-M.
Documentation
New porting guide for PSA targets will be provided in a separate Mbed OS PR.
Pull request type
Test results
Reviewers
@Devran01 @jainvikas8