-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Toshiba targets (AdBun-M066, M3H6 & M3HQ). #12746
Conversation
@deepak-shreshti, thank you for your changes. |
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
2 similar comments
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
@deepak-shreshti Can you please rebase ? There was a big clean up merge today , we will restart CI and this should be integrated soon. Thanks |
Pull request has been modified.
Hi @0xc0170 , Rebased with master and resolved the conflict. |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
@deepak-shreshti Thanks, unfortunately there were other changes (there are more than usual changes to targets.json this week), please rebase. I'll keep this opened to start CI right away to get it in |
--- AdBun-M066 Removed from targets.json https://github.com/ARMmbed/mbed-os/blob/5d64e558801940b3be547c3d059f28eaabc23f95/targets/targets.json#L12900-L12941 Deleted directory https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_TOSHIBA/TARGET_TMPM066 Removed from mbed_rtx.h https://github.com/ARMmbed/mbed-os/blob/5d64e558801940b3be547c3d059f28eaabc23f95/targets/TARGET_TOSHIBA/mbed_rtx.h#L23-L33 --- AdBun-M3H6 Removed from targets.json https://github.com/ARMmbed/mbed-os/blob/5d64e558801940b3be547c3d059f28eaabc23f95/targets/targets.json#L13465-L13507 Deleted directory https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_TOSHIBA/TARGET_TMPM3H6 Removed from mbed_rtx.h https://github.com/ARMmbed/mbed-os/blob/5d64e558801940b3be547c3d059f28eaabc23f95/targets/TARGET_TOSHIBA/mbed_rtx.h#L47-L53 --- AdBun-M3HQ Removed from targets.json https://github.com/ARMmbed/mbed-os/blob/5d64e558801940b3be547c3d059f28eaabc23f95/targets/targets.json#L14159-L14208 Deleted directory https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_TOSHIBA/TARGET_TMPM3HQ Removed from mbed_rtx.h https://github.com/ARMmbed/mbed-os/blob/5d64e558801940b3be547c3d059f28eaabc23f95/targets/TARGET_TOSHIBA/mbed_rtx.h#L63-L69 ---
Hi @0xc0170, Thanks for the review, rebased and resolved the conflict with the master. |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Removed below Toshiba targets from the mbed-os github:-
AdBun-M066
Removed from targets.json
mbed-os/targets/targets.json
Lines 12900 to 12941 in 5d64e55
Deleted directory
https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_TOSHIBA/TARGET_TMPM066
Removed from mbed_rtx.h
mbed-os/targets/TARGET_TOSHIBA/mbed_rtx.h
Lines 23 to 33 in 5d64e55
AdBun-M3H6
Removed from targets.json
mbed-os/targets/targets.json
Lines 13465 to 13507 in 5d64e55
Deleted directory
https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_TOSHIBA/TARGET_TMPM3H6
Removed from mbed_rtx.h
mbed-os/targets/TARGET_TOSHIBA/mbed_rtx.h
Lines 47 to 53 in 5d64e55
AdBun-M3HQ
Removed from targets.json
mbed-os/targets/targets.json
Lines 14159 to 14208 in 5d64e55
Deleted directory
https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_TOSHIBA/TARGET_TMPM3HQ
Removed from mbed_rtx.h
mbed-os/targets/TARGET_TOSHIBA/mbed_rtx.h
Lines 63 to 69 in 5d64e55
Summary of changes
Impact of changes
These targets are now removed from Mbed OS 6:
AdBun-M066
AdBun-M3H6
AdBun-M3HQ
Migration actions required
Use previous Mbed OS 5.x version for these targets.
Documentation
None
Not needed for target removal like this.
Pull request type
Test results
Reviewers