nRF: use Mbed-default boot-stack-size & fix stack_size_unification test #12874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
commented
Apr 27, 2020
| @@ -79,12 +79,6 @@ | |||
| "MCU_NRF51": { | |||
There was a problem hiding this comment.
Should I also remove NRF51 since they're deprecated now?
There was a problem hiding this comment.
Oh actually it's fine to remove it, because the option is more related to SoftDevice (which we removed) rather than NRF51 or 52. We use target names because the config cannot check SoftDevice directly.
|
@LDong-Arm, thank you for your changes. |
evedon
previously approved these changes
Apr 27, 2020
| @@ -79,12 +79,6 @@ | |||
| "MCU_NRF51": { | |||
…used Previously we overrode nRF targets to have a larger stack due to memory required by SoftDevice. Having deprecated SoftDevice in favour of Cordio for BLE (ARMmbed#12674), such requirement does not apply anymore.
LDong-Arm
force-pushed
the
nrf52_stack_size
branch
from
3672e96
to
81e676b
Compare
|
@evedon Thanks for the review |
LDong-Arm
changed the title
0xc0170
approved these changes
Apr 28, 2020
MarceloSalazar
approved these changes
Apr 28, 2020
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
mergify
bot
added
the
release version missing
|
This PR does not contain release version label after merging. |
0xc0170
added
release-version: 6.0.0-beta-1
and removed
release version missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The global default stack sizes for Mbed OS are
Previously, we overrode nRF targets to have a larger stack (
0x800) for RTOS due to memory required by the (SDK-side) SoftDevice BLE stack. Having removed SoftDevice in favour of Cordio (PR #12674), such requirement does not apply anymore.As for stack_size_unification test, it failed in a recent nightly CI after we made it available for bare-metal (PR #12827). Removing the
NRF5xmacro (for the reason above) fixes the test.Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Manual tests
Reviewers
@jamesbeyond @evedon @kjbracey-arm @mprse @MarceloSalazar