Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nRF51 targets #12961

Merged
merged 1 commit into from
May 15, 2020
Merged

Remove nRF51 targets #12961

merged 1 commit into from
May 15, 2020

Conversation

MarceloSalazar
Copy link

Summary of changes

This is another of a series of PRs (others #12775, #12810, #12864, #12935) to remove targets that are not supported or retired as explained in recent blog post.

Impact of changes

The following public nRF51 targets are being removed:

  • NRF51822
  • NRF51_DK
  • NRF51_MICROBIT

Migration actions required

  • The targets listed above continue to be available in the 5.15 branch.

Documentation

  • None.
    We'll update os.mbed.com/platforms with the list of supported platforms for Mbed 6

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Expect regressions tests to be done by CI as part of this PR.

Reviewers

@ARMmbed/mbed-os-maintainers

@ciarmcom
Copy link
Member

@MarceloSalazar, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test @ARMmbed/mbed-os-core please review.

The following public nRF51 targets are being removed:

- NRF51822
- NRF51_DK
- NRF51_MICROBIT
@ghost
Copy link

ghost commented May 13, 2020

so which other nrf5x targets are being removed? I also think linking to that blog post isn't enough, since it lists a few different reasons which don't apply to every board you're removing.

@mbed-ci
Copy link

mbed-ci commented May 13, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented May 13, 2020

I also think linking to that blog post isn't enough, since it lists a few different reasons which don't apply to every board you're removing.

Can you elaborate what we should document / change ? regarding the reason for being removed.

@ghost
Copy link

ghost commented May 13, 2020

Removed for low usage isn't the same as being removed because the hardware is obsolete.

EDIT: afaict, the bbc:microbit isn't either of those, so it must even be a different reason than those.

@ghost
Copy link

ghost commented May 13, 2020

I still want to know how far this removal is going, in case in need to switch away from mbed-os.

@MarceloSalazar
Copy link
Author

MarceloSalazar commented May 13, 2020

Other nrf5x targets are listed here: #12810, #12864

All of them fall in at least one of the categories shown in the blog post. The most common is that they're not officially supported in Mbed OS 6+

Note this doesn't mean that can't be used. It's being done in a slightly different way. See examples in forums:
https://forums.mbed.com/c/custom-and-community-boards/

More info in this blog post
https://os.mbed.com/blog/entry/Custom-and-community-board-support/

@0xc0170 0xc0170 requested a review from bulislaw May 13, 2020 17:51
@0xc0170 0xc0170 removed request for a team May 13, 2020 17:51
@0xc0170
Copy link
Contributor

0xc0170 commented May 15, 2020

I'll merge this one as agreed internally earlier

@0xc0170 0xc0170 merged commit 37ee008 into ARMmbed:master May 15, 2020
@MarceloSalazar MarceloSalazar deleted the remove_nrf51 branch May 15, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants