Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation update - MBRBlockDevice::partition type parameter #13019

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Documentation update - MBRBlockDevice::partition type parameter #13019

merged 1 commit into from
Jun 5, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented May 26, 2020 •
edited
Loading

Summary of changes

Added Doxygen note about MBRBlockDevice::partition type parameter usage and link to wiki page for the List of partition types or IDs.

fixes ARMmbed/mbed-os-5-docs#673

Impact of changes

With these changes, Mbed OS documentation provides clear information about MBRBlockDevice::partition type parameter.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@mergify mergify bot added the needs: work label May 26, 2020
@ciarmcom ciarmcom requested a review from evedon May 26, 2020 19:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team May 26, 2020 19:00
evedon
evedon previously requested changes May 27, 2020
View reviewed changes
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
@mergify mergify bot removed the needs: review label May 27, 2020
ithinuel
ithinuel suggested changes May 27, 2020
View reviewed changes
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
@mergify mergify bot dismissed evedon’s stale review May 27, 2020 15:15

Pull request has been modified.

evedon
evedon previously approved these changes May 27, 2020
View reviewed changes
@mergify mergify bot dismissed evedon’s stale review May 28, 2020 10:54

Pull request has been modified.

LDong-Arm
LDong-Arm approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
features/storage/blockdevice/MBRBlockDevice.h Outdated Show resolved Hide resolved
ithinuel
ithinuel approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: work labels May 28, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels May 29, 2020
@mbed-ci
Copy link

mbed-ci commented May 29, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2020

The issue is not related to this PR but one for rc2.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed mergify skip needs: CI labels Jun 5, 2020
@0xc0170 0xc0170 merged commit b076ea5 into ARMmbed:master Jun 5, 2020
@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 5, 2020
@mergify
Copy link

mergify bot commented Jun 5, 2020

This PR does not contain release version label after merging.

@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iriark01 iriark01 iriark01 left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@ithinuel ithinuel ithinuel approved these changes

@evedon evedon evedon approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@hugueskamba hugueskamba Awaiting requested review from hugueskamba

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MBRBlockDevice::partition - type
10 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @ithinuel @iriark01 @evedon @hugueskamba @LDong-Arm @adbridge