Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix esp8266 driver compilation warning #13144

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Fix esp8266 driver compilation warning #13144

merged 1 commit into from
Jun 18, 2020

Conversation

rajkan01
Copy link
Contributor

Summary of changes

Removed the unused variable and the redundant const return from set_ip_addr() function to fix compilation warnings.

Impact of changes

With these changes, no more compilation warning get reported during the build.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Jun 17, 2020
@rajkan01 rajkan01 force-pushed the fix_esp_driver_compilation_warnings branch from 8fc3d09 to 3e2e074 Compare June 17, 2020 17:47
@ciarmcom ciarmcom requested review from a team June 17, 2020 19:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

gpsimenos
gpsimenos approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@gpsimenos gpsimenos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 18, 2020
@0xc0170 0xc0170 merged commit 51446de into ARMmbed:master Jun 18, 2020
@mergify mergify bot removed the ready for merge label Jun 18, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@gpsimenos gpsimenos gpsimenos approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @gpsimenos @adbridge