Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 custom target: create MCU_STM32xx for each family #13229

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

In order to help custom targets support, I propose to create in targets.json file,
for each STM32 family, a MCU_STM32xx intermediate configuration.

Now, when you create a custom target, you don't need to copy all common information that customer doesn't know,
only need to add "inherits": "MCU_STM32L4" for ex

Impact of changes

Should be none...

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

I started ST CI for this week end.

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar
@ARMmbed/team-st-mcd


@mergify mergify bot added the needs: work label Jul 3, 2020
@ciarmcom ciarmcom requested review from MarceloSalazar and a team July 3, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 3, 2020

@jeromecoutant, thank you for your changes.
@MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2020

@jeromecoutant Please review Travis failures

Also, can you add details to the commit message? Why are we doing this and how the new inheritance should look like.

@ladislas
Copy link
Contributor

ladislas commented Jul 6, 2020

This is good news! As we are working on a custom board at the moment, everything that can make it easier is welcome! :)

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant Please review Travis failures

Please merge #13237 first

Also, can you add details to the commit message? Why are we doing this and how the new inheritance should look like.

Done

@jeromecoutant
Copy link
Collaborator Author

Let's restart travis ?
Thx

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

@jeromecoutant Can you rebase on top of master please?

@0xc0170 0xc0170 added needs: work release-type: patch Indentifies a PR as containing just a patch and removed needs: preceding PR labels Jul 9, 2020
Each target based on STM32 MCU can now inherit
common configuration defined by its STM32 family.
@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant Can you rebase on top of master please?

Done

travis needs to compile a target which doesn't support FLASHIAP
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having families +1

@jeromecoutant
Copy link
Collaborator Author

Let's start CI ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants