Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update arm-none-eabi- version #13435

Merged
merged 1 commit into from Aug 21, 2020
Merged

ci: Update arm-none-eabi- version #13435

merged 1 commit into from Aug 21, 2020

Conversation

urutva
Copy link
Contributor

@urutva urutva commented Aug 14, 2020

Summary of changes

The arm-none-eabi- version is updated from version 6 to version 9.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 14, 2020
@ciarmcom ciarmcom requested review from jamesbeyond and a team August 14, 2020 17:30
@ciarmcom
Copy link
Member

@urutva, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Aug 15, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Aug 15, 2020
jamesbeyond
jamesbeyond reviewed Aug 15, 2020
View reviewed changes
tools/test/travis-ci/functions.sh Outdated
@@ -59,7 +59,7 @@ _install_gcc()
{
# Ignore shellcheck warnings: Variables defined in .travis.yml
# shellcheck disable=SC2154
local url="${deps_url}/gcc6-linux.tar.bz2"
local url="${deps_url}/gcc9-linux.tar.bz2"

# shellcheck disable=SC2154
local gcc_path="${deps_dir}/gcc/gcc-arm-none-eabi-6-2017-q2-update/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to change this as well, should be gcc-arm-none-eabi-9-2019-q4-major, but I don't know why Travis CI still Passing ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is arm-none-eabi-gcc been used at all ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is used for event/littlefs builds. the logs now are

I: URL: https://mbed-os-ci.s3-eu-west-1.amazonaws.com/jenkins-ci/deps/gcc9-linux.tar.bz2
I: Installing 'gcc'
install.2
0.01s$ arm-none-eabi-gcc --version
arm-none-eabi-gcc (GNU Tools for ARM Embedded Processors 6-2017-q2-update) 6.3.1 20170620 (release) [ARM/embedded-6-branch revision 249437]
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

python tools/make.py -t GCC_ARM -m K64F --source=. --build=BUILD/K64F/GCC_ARM -j0
[Warning] @,: Compiler version mismatch: Have 6.3.1; expected version >= 9.0.0 and < 10.0.0

Copy link
Contributor Author

@urutva urutva Aug 17, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 @jamesbeyond
There seems to be another bug in Travis config. What is the expectation from Travis? Validate PR contents? then it doesn't seems to be doing what it is intended for. I do not see it fetching the PR contents in the config. May be I'm missing something?

I'm speculating this because, Travis succeeded on this PR and the log shows https://travis-ci.org/github/ARMmbed/mbed-os/jobs/717990846 arm-none-eabi version 6 in the PATH which shouldn't have happened with this PR. The travis job should have failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis didn't fail and reported arm-none-eabi version 6 because the version 6 was cached.
arm-none-eabi version 9 is uploaded and configured in Travis and the old cache has been removed.

@urutva urutva force-pushed the fix-arm-none-eab-gcc-version branch from 1759b2e to 99cebee Compare August 17, 2020 09:56
@mergify mergify bot dismissed 0xc0170’s stale review August 17, 2020 09:56

Pull request has been modified.

@urutva urutva force-pushed the fix-arm-none-eab-gcc-version branch 6 times, most recently from 143bcda to 9c79313 Compare August 17, 2020 14:35
@urutva
ci: Update arm-none-eabi- version
85e0199 
The `arm-none-eabi-` version is updated from version 6 to version 9.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
@urutva urutva force-pushed the fix-arm-none-eab-gcc-version branch from 9c79313 to 85e0199 Compare August 17, 2020 15:18
@mbed-ci
Copy link

mbed-ci commented Aug 17, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@urutva urutva mentioned this pull request Aug 20, 2020
Merged
@0xc0170 0xc0170 merged commit 76d51a5 into ARMmbed:master Aug 21, 2020
@mergify mergify bot removed the ready for merge label Aug 21, 2020
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
release-version: 6.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@urutva @ciarmcom @mbed-ci @0xc0170 @jamesbeyond @mbedmain